Attachment 79315 Details for Bug 64601 – patch for get_le32()

patch for get_le32()

fix-unaligned-access-warnings-on-big-endian-machines (text/plain), 995 bytes, created by Helge Deller on 2013-05-14 19:52:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Helge Deller

Created: 2013-05-14 19:52:13 UTC

Size: 995 bytes

patch

obsolete

>Description: fix unaligned access warnings on big endian machines
>
> On big endian machines (in my case parisc) unaligned accesses to 32bit
> integers gives warnings during boot like this:
>
> udisks-part-id(3035): unaligned access to 0xc06d29ce at ip=0x00012a03
> udisks-part-id(3035): unaligned access to 0xc06d29d2 at ip=0x00012a3b
> udisks-part-id(3035): unaligned access to 0xc06d29de at ip=0x00012a03
> udisks-part-id(3035): unaligned access to 0xc06d29e2 at ip=0x00012a3b
> udisks-part-id(3035): unaligned access to 0xc06d29ee at ip=0x00012a03
>
> Fix this by copying the 4 bytes to an aligned address and then access
> it.
>
>Author: Helge Deller <deller@gmx.de>
>
>--- udisks-1.0.4.orig/src/helpers/partutil.c
>+++ udisks-1.0.4/src/helpers/partutil.c
>@@ -181,7 +181,9 @@ get_le16 (const void *buf)
> static guint32
> get_le32 (const void *buf)
> {
>-  return GUINT32_FROM_LE (*((guint32 *) buf));
>+  guint32 le32;
>+  memcpy(&le32, buf, sizeof(le32));
>+  return GUINT32_FROM_LE (le32);
> }
> 
> static guint64

Actions: View

Attachments on bug 64601: 79315

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.