Attachment 79892 Details for Bug 65036 – tests: fix JabberAuthenticator when self.emit_events is False

[patch] tests: fix JabberAuthenticator when self.emit_events is False

0003-tests-fix-JabberAuthenticator-when-self.emit_events-.patch (text/plain), 1.02 KB, created by Simon McVittie on 2013-05-28 12:10:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-05-28 12:10:08 UTC

Size: 1.02 KB

patch

obsolete

>From 40008d7a49f107feee522fff81d914b531f18e77 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Tue, 28 May 2013 12:04:44 +0100
>Subject: [PATCH 3/4] tests: fix JabberAuthenticator when self.emit_events is
> False
>
>We don't currently use JabberAuthenticator in this mode, so nobody
>noticed that it didn't work. I'm about to add a test that does use it.
>---
> tests/twisted/gabbletest.py |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tests/twisted/gabbletest.py b/tests/twisted/gabbletest.py
>index 2ee15dd..aa63c6d 100644
>--- a/tests/twisted/gabbletest.py
>+++ b/tests/twisted/gabbletest.py
>@@ -160,7 +160,7 @@ class JabberAuthenticator(GabbleAuthenticator):
>             self._event_func(Event('auth-second-iq', authenticator=self,
>                 iq=iq, id=iq["id"]))
>         else:
>-            self.respondToSecondIq(self, iq)
>+            self.respondToSecondIq(iq)
> 
>     def respondToSecondIq(self, iq):
>         username = xpath.queryForNodes('/iq/query/username', iq)
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 65036: 79847 | 79891 | 79892 | 79893 | 79894 | 79953 | 79974

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.