Attachment 80213 Details for Bug 65293 – Pass on all AM_CPPFLAGS and CPPFLAGS to g-ir-scanner

[patch] Pass on all AM_CPPFLAGS and CPPFLAGS to g-ir-scanner

0001-Pass-on-all-AM_CPPFLAGS-and-CPPFLAGS-to-g-ir-scanner.patch (text/plain), 1.19 KB, created by Simon McVittie on 2013-06-03 11:25:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-06-03 11:25:25 UTC

Size: 1.19 KB

patch

obsolete

>From 541806dc0937ae71c7ec9505f3335dfe7c7ffd73 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Tue, 28 May 2013 09:56:49 +0100
>Subject: [PATCH] Pass on all AM_CPPFLAGS and CPPFLAGS to g-ir-scanner
>
>Failure to do so causes a false-positive in Debian's build log checks,
>which check that "hardening" flags are passed to all compilations.
>---
> telepathy-glib/introspection.am |    4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/telepathy-glib/introspection.am b/telepathy-glib/introspection.am
>index 4789942..cd892d5 100644
>--- a/telepathy-glib/introspection.am
>+++ b/telepathy-glib/introspection.am
>@@ -87,7 +87,9 @@ TelepathyGLib_0_12_gir_FILES = \
> TelepathyGLib_0_12_gir_NAMESPACE = TelepathyGLib
> TelepathyGLib_0_12_gir_VERSION = 0.12
> TelepathyGLib_0_12_gir_LIBS = libtelepathy-glib.la
>-TelepathyGLib_0_12_gir_CFLAGS = -D_TP_COMPILATION
>+# g-ir-scanner picks up CFLAGS from the environment, but not CPPFLAGS.
>+# We don't want to give it our AM_CFLAGS, which include extra warnings.
>+TelepathyGLib_0_12_gir_CFLAGS = $(AM_CPPFLAGS) $(CPPFLAGS)
> TelepathyGLib_0_12_gir_EXPORT_PACKAGES = telepathy-glib
> 
> TelepathyGLib_0_12_gir_SCANNERFLAGS = \
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 65293: 80213

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.