Attachment 81101 Details for Bug 65959 – [PATCH] DBusString: fix may crash if try to free an uninitialized str

[patch] [PATCH] DBusString: fix may crash if try to free an uninitialized str

0001-DBusString-fix-may-crash-if-try-to-free-an-uninitial.patch (text/plain), 1.06 KB, created by Chengwei Yang on 2013-06-20 09:32:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chengwei Yang

Created: 2013-06-20 09:32:44 UTC

Size: 1.06 KB

patch

obsolete

>From 16b2301db9b45fb7d74a5cb53b0638b31314a663 Mon Sep 17 00:00:00 2001
>From: Chengwei Yang <chengwei.yang@intel.com>
>Date: Thu, 20 Jun 2013 17:24:04 +0800
>Subject: [PATCH] DBusString: fix may crash if try to free an uninitialized
> str
>
>If the str will be freed hasn't been initialized by _dbus_string_init
>correctly, _dbus_string_free may crash due to trying to free an
>undefined memory.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65959
>
>Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
>---
> dbus/dbus-string.c |    8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/dbus/dbus-string.c b/dbus/dbus-string.c
>index e3766aa..52eb0f2 100644
>--- a/dbus/dbus-string.c
>+++ b/dbus/dbus-string.c
>@@ -246,6 +246,14 @@ _dbus_string_free (DBusString *str)
>   
>   if (real->constant)
>     return;
>+
>+  /* so it's safe if @p str returned by a failed
>+   * _dbus_string_init call
>+   * Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65959
>+   */
>+  if (real->str == NULL)
>+    return;
>+
>   dbus_free (real->str - real->align_offset);
> 
>   real->invalid = TRUE;
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 65959: 81100 | 81101

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.