Attachment 8118 Details for Bug 9350 – Patch to correct the text-rotate behaviour

[patch] Patch to correct the text-rotate behaviour

sqrt-patch.txt (text/plain), 1.69 KB, created by Brian Ewins on 2006-12-14 19:37:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brian Ewins

Created: 2006-12-14 19:37:55 UTC

Size: 1.69 KB

patch

obsolete

>Calculate the size of an ATSUI font by finding the magnitude of a unit
>vector scaled using the current ctm. This calculation is only correct
>for isotropic scaling and translation, but correctly implements the
>intent of the old code.
>
>---
>commit e26db8db0d0e6a475589308419f869d3e1ef46ad
>tree 28f0d9079824a25e254106901581b2a84d12a99c
>parent 15e8486ef1558b8049a4c7a5c2f50a7e4a2599da
>author Brian Ewins <Brian.Ewins@gmail.com> Fri, 15 Dec 2006 03:08:26 +0000
>committer Brian Ewins <Brian.Ewins@gmail.com> Fri, 15 Dec 2006 03:08:26 +0000
>
> src/cairo-atsui-font.c |   11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/src/cairo-atsui-font.c b/src/cairo-atsui-font.c
>index 2927caa..74498c1 100644
>--- a/src/cairo-atsui-font.c
>+++ b/src/cairo-atsui-font.c
>@@ -152,11 +152,12 @@ CreateSizedCopyOfStyle(ATSUStyle inStyle
>     OSStatus err;
> 
>     /* Set the style's size */
>-    CGAffineTransform theTransform =
>-        CGAffineTransformMakeWithCairoFontScale(scale);
>-    Fixed theSize =
>-        FloatToFixed(CGSizeApplyAffineTransform
>-                     (CGSizeMake(1.0, 1.0), theTransform).height);
>+    /* XXX The size calculated here is only correct for transposition and isotropic
>+     * scaling. Cairo does not yet have tests for anisotropic scaling or shear.
>+     * However, it would be faster and more correct to set a size here and
>+     * use the ctm to transform the font later, instead of using sqrt. 
>+     */
>+    Fixed theSize = FloatToFixed(sqrt(scale->xx * scale->xx + scale->xy * scale->xy));
>     const ATSUAttributeTag theFontStyleTags[] = { kATSUSizeTag };
>     const ByteCount theFontStyleSizes[] = { sizeof(Fixed) };
>     ATSUAttributeValuePtr theFontStyleValues[] = { &theSize };

Actions: View | Splinter Review

Attachments on bug 9350: 8117 | 8118 | 8119 | 8143 | 8152 | 8153 | 8154 | 8190 | 8191 | 8192 | 8193 | 8194

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.