Attachment 81590 Details for Bug 65953 – don't tear down un-initiaizled stolen drm_mm

[patch] don't tear down un-initiaizled stolen drm_mm

0001-drm-i915-Don-t-try-to-tear-down-the-stolen-drm_mm-if.patch (text/plain), 1.21 KB, created by Daniel Vetter on 2013-06-27 23:04:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Vetter

Created: 2013-06-27 23:04:37 UTC

Size: 1.21 KB

patch

obsolete

>From e89ef28fe31c366abe099a56273a26e5104f4dd1 Mon Sep 17 00:00:00 2001
>From: Daniel Vetter <daniel.vetter@ffwll.ch>
>Date: Fri, 28 Jun 2013 01:01:05 +0200
>Subject: [PATCH] drm/i915: Don't try to tear down the stolen drm_mm if it's
> not there
>
>Every other place properly checks whether we've managed to set
>up the stolen allocator at boot-up properly, with the exception
>of the cleanup code. Which results in an ugly
>
>*ERROR* Memory manager not clean. Delaying takedown
>
>at module unload time since the drm_mm isn't initialized at all.
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=65953
>Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>---
> drivers/gpu/drm/i915/i915_gem_stolen.c |    3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c
>index f713294..78340ea 100644
>--- a/drivers/gpu/drm/i915/i915_gem_stolen.c
>+++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
>@@ -179,6 +179,9 @@ void i915_gem_cleanup_stolen(struct drm_device *dev)
> {
> 	struct drm_i915_private *dev_priv = dev->dev_private;
> 
>+	if (dev_priv->mm.stolen_base == 0)
>+		return;
>+
> 	i915_gem_stolen_cleanup_compression(dev);
> 	drm_mm_takedown(&dev_priv->mm.stolen);
> }
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 65953: 81380 | 81590 | 81778 | 81791 | 81844 | 81845

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.