Attachment 81616 Details for Bug 66300 – [PATCH 4/4] DBusString: fix a typo and check byte value strictly

[patch] [PATCH 4/4] DBusString: fix a typo and check byte value strictly

0004-DBusString-fix-a-typo-and-check-byte-value-strictly.patch (text/plain), 1.14 KB, created by Chengwei Yang on 2013-06-28 06:53:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chengwei Yang

Created: 2013-06-28 06:53:50 UTC

Size: 1.14 KB

patch

obsolete

>From 62904d82d51fe5d2534fe94773f4d155c071a266 Mon Sep 17 00:00:00 2001
>From: Chengwei Yang <chengwei.yang@intel.com>
>Date: Fri, 28 Jun 2013 14:40:42 +0800
>Subject: [PATCH 4/4] DBusString: fix a typo and check byte value strictly
>
>Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
>---
> dbus/dbus-string.c |    5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/dbus/dbus-string.c b/dbus/dbus-string.c
>index 52eb0f2..57367b2 100644
>--- a/dbus/dbus-string.c
>+++ b/dbus/dbus-string.c
>@@ -977,7 +977,7 @@ do {                                            \
> dbus_bool_t
> _dbus_string_insert_2_aligned (DBusString         *str,
>                                int                 insert_at,
>-                               const unsigned char octets[4])
>+                               const unsigned char octets[2])
> {
>   DBUS_STRING_PREAMBLE (str);
>   
>@@ -2235,6 +2235,9 @@ _dbus_string_append_byte_as_hex (DBusString *str,
>     'a', 'b', 'c', 'd', 'e', 'f'
>   };
> 
>+  if (byte < 0 || byte > 0xff)
>+    return FALSE;
>+
>   if (!_dbus_string_append_byte (str,
>                                  hexdigits[(byte >> 4)]))
>     return FALSE;
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 66300: 81612 | 81613 | 81615 | 81616

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.