Attachment 82573 Details for Bug 54445 – [PATCH] Fix build with "--enable-stats"

[patch] [PATCH] Fix build with "--enable-stats"

0001-Fix-build-with-enable-stats.patch (text/plain), 1.47 KB, created by Chengwei Yang on 2013-07-18 07:55:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chengwei Yang

Created: 2013-07-18 07:55:50 UTC

Size: 1.47 KB

patch

obsolete

>From a3e01449e956b1fab5deb0d1e0be951e535199eb Mon Sep 17 00:00:00 2001
>From: Chengwei Yang <chengwei.yang@intel.com>
>Date: Thu, 18 Jul 2013 15:53:47 +0800
>Subject: [PATCH] Fix build with "--enable-stats"
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54445
>Signed-off-by: Chengwei Yang <chengwei.yang@intel.com>
>---
> bus/stats.c |   14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
>diff --git a/bus/stats.c b/bus/stats.c
>index 0c71a54..6da611a 100644
>--- a/bus/stats.c
>+++ b/bus/stats.c
>@@ -166,7 +166,19 @@ bus_stats_handle_get_connection_stats (DBusConnection *caller_connection,
>       !_dbus_asv_add_uint32 (&arr_iter, "PeakBusNames",
>         bus_connection_get_peak_bus_names (stats_connection)) ||
>       !_dbus_asv_add_uint32 (&arr_iter, "UniqueName",
>-        bus_connection_get_name (stats_connection)))
>+        /*
>+         * need a dbus_uint32_t but get a const char *, which sizeof
>+         * equals sizeof (unsigned long).
>+         * dbus_uint32_t here couldn't compile on x86_64 host because
>+         * sizeof (unsigned long) != sizeof (unsigned int), so we'll
>+         * get error=pointer-to-int-cast
>+         *
>+         * However, we'll dead if we get an address larger than
>+         * UINT_MAX, Will it happen?
>+         *
>+         * FIXME: should we use unsigned long instead of unsigned int?
>+         */
>+        (unsigned long) bus_connection_get_name (stats_connection)))
>     {
>       _dbus_asv_abandon (&iter, &arr_iter);
>       goto oom;
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 54445: 66552 | 66554 | 66555 | 66559 | 66569 | 66578 | 66626 | 66629 | 66741 | 75650 | 75651 | 75652 | 75653 | 75654 | 75689 | 76017 | 76018 | 81340 | 81341 | 81342 | 81389 | 82573 | 82643 | 84562 | 84801 | 84802 | 84804 | 113318 | 113319 | 113321 | 113330 | 113360

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.