Attachment 8281 Details for Bug 9526 – Properly set length field in gradient requests

[patch] Properly set length field in gradient requests

libXrender-gradient-length-fix.diff (text/plain), 1.99 KB, created by David Reveman on 2007-01-03 06:19:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Reveman

Created: 2007-01-03 06:19:37 UTC

Size: 1.99 KB

patch

obsolete

>diff --git a/src/Picture.c b/src/Picture.c
>index 0b18f5c..509a835 100644
>--- a/src/Picture.c
>+++ b/src/Picture.c
>@@ -277,6 +277,7 @@ Picture XRenderCreateLinearGradient(Display *dpy,
>     XRenderExtDisplayInfo	    *info = XRenderFindDisplay (dpy);
>     Picture		    pid;
>     xRenderCreateLinearGradientReq *req;
>+    long			   len;
> 
>     RenderCheckExtension (dpy, info, 0);
>     LockDisplay(dpy);
>@@ -291,9 +292,10 @@ Picture XRenderCreateLinearGradient(Display *dpy,
>     req->p2.y = gradient->p2.y;
> 
>     req->nStops = nStops;
>+    len = (long) nStops * 3;
>+    SetReqLen (req, len, 6);
>     DataInt32(dpy, stops, nStops * 4);
>     Data16(dpy, colors, nStops * 8);
>-    req->length += nStops*3;
> 
>     UnlockDisplay(dpy);
>     SyncHandle();
>@@ -309,6 +311,7 @@ Picture XRenderCreateRadialGradient(Display *dpy,
>     XRenderExtDisplayInfo	    *info = XRenderFindDisplay (dpy);
>     Picture		    pid;
>     xRenderCreateRadialGradientReq *req;
>+    long			   len;
> 
>     RenderCheckExtension (dpy, info, 0);
>     LockDisplay(dpy);
>@@ -325,9 +328,10 @@ Picture XRenderCreateRadialGradient(Display *dpy,
>     req->outer_radius = gradient->outer.radius;
> 
>     req->nStops = nStops;
>+    len = (long) nStops * 3;
>+    SetReqLen (req, len, 6);
>     DataInt32(dpy, stops, nStops * 4);
>     Data16(dpy, colors, nStops * 8);
>-    req->length += nStops*3;
> 
>     UnlockDisplay(dpy);
>     SyncHandle();
>@@ -343,6 +347,7 @@ Picture XRenderCreateConicalGradient(Display *dpy,
>     XRenderExtDisplayInfo	    *info = XRenderFindDisplay (dpy);
>     Picture		    pid;
>     xRenderCreateConicalGradientReq *req;
>+    long			    len;
> 
>     RenderCheckExtension (dpy, info, 0);
>     LockDisplay(dpy);
>@@ -356,9 +361,10 @@ Picture XRenderCreateConicalGradient(Display *dpy,
>     req->angle = gradient->angle;
> 
>     req->nStops = nStops;
>+    len = (long) nStops * 3;
>+    SetReqLen (req, len, 6);
>     DataInt32(dpy, stops, nStops * 4);
>     Data16(dpy, colors, nStops * 8);
>-    req->length += nStops*3;
> 
>     UnlockDisplay(dpy);
>     SyncHandle();

Actions: View | Splinter Review

Attachments on bug 9526: 8281

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.