Attachment 83262 Details for Bug 67516 – patch 3/3

patch 3/3

0003-mesa-fix-proxy-textures-becoming-immutable-and-unusa.patch (text/plain), 1.16 KB, created by Mikko Juola on 2013-07-30 04:15:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mikko Juola

Created: 2013-07-30 04:15:08 UTC

Size: 1.16 KB

patch

obsolete

>From 80cdca25f10e3aee2ac55f44aa34a13870c5eeba Mon Sep 17 00:00:00 2001
>From: Mikko Juola <mikjuo@gmail.com>
>Date: Tue, 30 Jul 2013 06:36:43 +0300
>Subject: [PATCH 3/3] mesa: fix proxy textures becoming immutable and unusable
>
>glTexStorage*() functions make textures immutable. This carries on to proxy
>textures. Error checking in texture storage functions prevents proxy textures
>from working after first time because internally, they became immutable.
>
>This commit makes the error checking ignore the immutability flag when working
>with proxy textures.
>---
> src/mesa/main/texstorage.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c
>index 7798897..7bd8652 100644
>--- a/src/mesa/main/texstorage.c
>+++ b/src/mesa/main/texstorage.c
>@@ -342,7 +342,7 @@ tex_storage_error_check(struct gl_context *ctx, GLuint dims, GLenum target,
>    }
> 
>    /* Check if texObj->Immutable is set */
>-   if (texObj->Immutable) {
>+   if (!_mesa_is_proxy_texture(target) && texObj->Immutable) {
>       _mesa_error(ctx, GL_INVALID_OPERATION, "glTexStorage%uD(immutable)",
>                   dims);
>       return GL_TRUE;
>-- 
>1.7.10.4
>

Actions: View

Attachments on bug 67516: 83259 | 83260 | 83261 | 83262 | 83319

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.