Attachment 83843 Details for Bug 66060 – Only take process id of localhost connections

[patch] Only take process id of localhost connections

0001-Only-take-process-id-of-localhost-connections.patch (text/plain), 1.68 KB, created by Ralf Habacker on 2013-08-08 15:04:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ralf Habacker

Created: 2013-08-08 15:04:20 UTC

Size: 1.68 KB

patch

obsolete

>From a1f855e6145350439f33c411dd67244a165aeeec Mon Sep 17 00:00:00 2001
>From: Ralf Habacker <ralf.habacker@freenet.de>
>Date: Thu, 8 Aug 2013 16:48:04 +0200
>Subject: [PATCH] Only take process id of localhost client connection entries.
>
>This patch makes sure, that the process id is fetched only from localhost
> client address connections fetched from the tcp table.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66060
>---
> dbus/dbus-sysdeps-win.c |    7 +++++--
> 1 Datei geÃ¤ndert, 5 Zeilen hinzugefÃ¼gt(+), 2 Zeilen entfernt(-)
>
>diff --git a/dbus/dbus-sysdeps-win.c b/dbus/dbus-sysdeps-win.c
>index 4fa1b89..35cf134 100644
>--- a/dbus/dbus-sysdeps-win.c
>+++ b/dbus/dbus-sysdeps-win.c
>@@ -210,7 +210,8 @@ _dbus_get_peer_pid_from_tcp_handle (int handle)
>       for (dwSize = 0; dwSize < lpBuffer->dwNumEntries; dwSize++)
>         {
>           int local_port = ntohs (lpBuffer->table[dwSize].dwLocalPort);
>-          if (local_port == peer_port)
>+          int local_address = htonl (lpBuffer->table[dwSize].dwLocalAddr);
>+          if (local_address == tINADDR_LOOPBACK && local_port == peer_port)
>             {
>               result = lpBuffer->table[dwSize].dwOwningPid;
>               break;
>@@ -246,8 +247,10 @@ _dbus_get_peer_pid_from_tcp_handle (int handle)
>   for (i = 0; i < tcp_table->dwNumEntries; i++)
>     {
>       MIB_TCPROW_OWNER_PID *p = &tcp_table->table[i];
>+      int local_address = htonl (p->dwLocalAddr);
>       int local_port = ntohs (p->dwLocalPort);
>-      if (p->dwState == MIB_TCP_STATE_ESTAB && local_port == peer_port)
>+      if (p->dwState == MIB_TCP_STATE_ESTAB
>+          && local_address == INADDR_LOOPBACK && local_port == peer_port)
>         result = p->dwOwningPid;
>     }
> 
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 66060: 82667 | 82670 | 83797 | 83832 | 83843 | 83844 | 83862 | 83863 | 83864 | 83865 | 83866 | 83891

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.