Attachment 84778 Details for Bug 68641 – tune down hangcheck noise

[patch] tune down hangcheck noise

0001-drm-i915-tune-down-hangcheck-noise.patch (text/plain), 1.41 KB, created by Daniel Vetter on 2013-08-28 09:00:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Vetter

Created: 2013-08-28 09:00:13 UTC

Size: 1.41 KB

patch

obsolete

>From 65dbfa295dd9d497d7d1f441b7dbed284c2bb17a Mon Sep 17 00:00:00 2001
>From: Daniel Vetter <daniel.vetter@ffwll.ch>
>Date: Wed, 28 Aug 2013 10:57:59 +0200
>Subject: [PATCH] drm/i915: tune down hangcheck noise
>
>We already have a big splashing *ERROR* for all the relevant cases of
>hangs, so this one here is redudant. And it results in an unclean
>dmesg when running with simulated hangs. Regression has been
>introduced in
>
>commit 05407ff889ceebe383aa5907219f86582ef96b72
>Author: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>Date:   Thu May 30 09:04:29 2013 +0300
>
>    drm/i915: detect hang using per ring hangcheck_score
>
>Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68641
>Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>---
> drivers/gpu/drm/i915/i915_irq.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
>index a03b445..4c6853f 100644
>--- a/drivers/gpu/drm/i915/i915_irq.c
>+++ b/drivers/gpu/drm/i915/i915_irq.c
>@@ -2027,9 +2027,9 @@ static void i915_hangcheck_elapsed(unsigned long data)
> 
> 	for_each_ring(ring, dev_priv, i) {
> 		if (ring->hangcheck.score > FIRE) {
>-			DRM_ERROR("%s on %s\n",
>-				  stuck[i] ? "stuck" : "no progress",
>-				  ring->name);
>+			DRM_INFO("%s on %s\n",
>+				 stuck[i] ? "stuck" : "no progress",
>+				 ring->name);
> 			rings_hung++;
> 		}
> 	}
>-- 
>1.8.4.rc3
>

Actions: View | Splinter Review

Attachments on bug 68641: 84774 | 84778

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.