Attachment 84832 Details for Bug 68610 – Comment some suspicious uses of static variables

[patch] Comment some suspicious uses of static variables

0003-Comment-some-suspicious-uses-of-static-variables.patch (text/plain), 1.36 KB, created by Simon McVittie on 2013-08-29 12:06:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-08-29 12:06:14 UTC

Size: 1.36 KB

patch

obsolete

>From d34c08bb6e380f32b5ce6d2c60debab54ba75783 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Thu, 29 Aug 2013 12:50:39 +0100
>Subject: [PATCH 3/5] Comment some suspicious uses of static variables
>
>---
> dbus/dbus-sysdeps-unix.c | 2 ++
> dbus/dbus-sysdeps-win.c  | 2 ++
> 2 files changed, 4 insertions(+)
>
>diff --git a/dbus/dbus-sysdeps-unix.c b/dbus/dbus-sysdeps-unix.c
>index 13e13ca..8ecbfd3 100644
>--- a/dbus/dbus-sysdeps-unix.c
>+++ b/dbus/dbus-sysdeps-unix.c
>@@ -3948,6 +3948,8 @@ _dbus_append_keyring_directory_for_credentials (DBusString      *directory,
>       }
>     else
>       {
>+        /* Not strictly thread-safe, but if we fail at thread-safety here,
>+         * the worst that will happen is some extra warnings. */
>         static dbus_bool_t already_warned = FALSE;
>         if (!already_warned)
>           {
>diff --git a/dbus/dbus-sysdeps-win.c b/dbus/dbus-sysdeps-win.c
>index 2f5e51f..1039cc6 100644
>--- a/dbus/dbus-sysdeps-win.c
>+++ b/dbus/dbus-sysdeps-win.c
>@@ -3622,6 +3622,8 @@ _dbus_append_keyring_directory_for_credentials (DBusString      *directory,
>       }
>     else
>       {
>+        /* Not strictly thread-safe, but if we fail at thread-safety here,
>+         * the worst that will happen is some extra warnings. */
>         static dbus_bool_t already_warned = FALSE;
>         if (!already_warned)
>           {
>-- 
>1.8.4.rc3
>

Actions: View | Splinter Review

Attachments on bug 68610: 84714 | 84715 | 84830 | 84831 | 84832 | 84833 | 84834 | 84837 | 85080 | 85113 | 85241

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.