Attachment 84886 Details for Bug 64923 – ServerConnection: dispose internal objects

[patch] ServerConnection: dispose internal objects

0002-ServerConnection-dispose-internal-objects.patch (text/plain), 1.07 KB, created by Lionel Landwerlin on 2013-08-29 23:02:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lionel Landwerlin

Created: 2013-08-29 23:02:06 UTC

Size: 1.07 KB

patch

obsolete

>From 1d550fbe355105aeedc0e84df23622e3bce77778 Mon Sep 17 00:00:00 2001
>From: Lionel Landwerlin <llandwerlin@gmail.com>
>Date: Thu, 29 Aug 2013 23:48:36 +0100
>Subject: [PATCH 2/2] ServerConnection: dispose internal objects
>
>---
> src/idle-server-connection.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/src/idle-server-connection.c b/src/idle-server-connection.c
>index a921c33..66fe3d0 100644
>--- a/src/idle-server-connection.c
>+++ b/src/idle-server-connection.c
>@@ -107,10 +107,10 @@ static void idle_server_connection_dispose(GObject *obj) {
> 	IdleServerConnection *conn = IDLE_SERVER_CONNECTION(obj);
> 	IdleServerConnectionPrivate *priv = IDLE_SERVER_CONNECTION_GET_PRIVATE(conn);
> 
>-	if (priv->socket_client != NULL) {
>-		g_object_unref(priv->socket_client);
>-		priv->socket_client = NULL;
>-	}
>+        g_clear_object (&priv->socket_client);
>+        g_clear_object (&priv->io_stream);
>+        g_clear_object (&priv->tls_manager);
>+        g_clear_object (&priv->read_cancellable);
> }
> 
> static void idle_server_connection_finalize(GObject *obj) {
>-- 
>1.8.4.rc3
>

Actions: View | Splinter Review

Attachments on bug 64923: 84885 | 84886

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.