Attachment 85790 Details for Bug 60340 – [5/6] _dbus_read_credentials_socket: warn or fail at compile time if no support

[patch] [5/6] _dbus_read_credentials_socket: warn or fail at compile time if no support

0005-_dbus_read_credentials_socket-warn-or-fail-at-compil.patch (text/plain), 1.66 KB, created by Simon McVittie on 2013-09-13 18:27:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-09-13 18:27:40 UTC

Size: 1.66 KB

patch

obsolete

>From 68b0ddb78f0b147bffc45a337ca16d5d54df866f Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Fri, 13 Sep 2013 19:01:04 +0100
>Subject: [PATCH 5/5] _dbus_read_credentials_socket: warn or fail at compile
> time if no support
>
>On a whitelist of OSs known to have working credentials-passing
>(currently FreeBSD, Linux, OpenBSD and NetBSD), it would be a
>regression for us to not have credentials-passing, so fail hard.
>
>On other OSs, raise a warning, which is not normally fatal but
>will alert developers on those platforms.
>---
> dbus/dbus-sysdeps-unix.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
>diff --git a/dbus/dbus-sysdeps-unix.c b/dbus/dbus-sysdeps-unix.c
>index 5904b4f..dfccf9a 100644
>--- a/dbus/dbus-sysdeps-unix.c
>+++ b/dbus/dbus-sysdeps-unix.c
>@@ -1859,6 +1859,21 @@ _dbus_read_credentials_socket  (int              client_fd,
>         _dbus_verbose ("Failed to getpeereid() credentials: %s\n", _dbus_strerror (errno));
>       }
> #else /* no supported mechanism */
>+
>+#warning Socket credentials not supported on this Unix OS
>+#warning Please tell https://bugs.freedesktop.org/enter_bug.cgi?product=DBus
>+
>+    /* Please add other operating systems known to support at least one of
>+     * the mechanisms above to this list, keeping alphabetical order.
>+     * Everything not in this list  is best-effort.
>+     */
>+#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || \
>+    defined(__linux__) || \
>+    defined(__OpenBSD__) || \
>+    defined(__NetBSD__)
>+# error Credentials passing not working on this OS is a regression!
>+#endif
>+
>     _dbus_verbose ("Socket credentials not supported on this OS\n");
> #endif
>   }
>-- 
>1.8.4.rc3
>

Actions: View | Splinter Review

Attachments on bug 60340: 74261 | 74677 | 74679 | 74680 | 74698 | 75145 | 85786 | 85787 | 85788 | 85789 | 85790 | 85791

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.