Attachment 85957 Details for Bug 66608 – [PATCH] Spec: two services offer the same service is only available for session bus

[patch] [PATCH] Spec: two services offer the same service is only available for session bus

0001-Spec-two-services-offer-the-same-service-is-only-ava.patch (text/plain), 2.20 KB, created by Chengwei Yang on 2013-09-17 09:57:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chengwei Yang

Created: 2013-09-17 09:57:20 UTC

Size: 2.20 KB

patch

obsolete

>From a4b79e012b7e96a35ab0136cd401c5b9a1a3579e Mon Sep 17 00:00:00 2001
>From: Chengwei Yang <chengwei.yang@intel.com>
>Date: Tue, 17 Sep 2013 17:44:33 +0800
>Subject: [PATCH] Spec: two services offer the same service is only available
> for session bus
>
>There is a new change in dbus spec that the name of service description
>file for the well-known system bus must be its well-known name plus
>.service. So the only case is there are two name.service files in
>different servicedir, however, since the load sequence of servicedir is
>defined in system bus configure file, it's determinable. In the session
>bus case, it loads .service file with readdir(2), it's undeterminable.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66608
>---
> dbus/dbus-connection.c     |    1 +
> doc/dbus-specification.xml |    6 +++---
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/dbus/dbus-connection.c b/dbus/dbus-connection.c
>index f0b6871..47d6878 100644
>--- a/dbus/dbus-connection.c
>+++ b/dbus/dbus-connection.c
>@@ -1098,6 +1098,7 @@ _dbus_connection_acquire_io_path (DBusConnection *connection,
>                * on our part. for now it doesn't matter, we will just
>                * end up back here eventually.)
>                */
>+               _dbus_verbose ("timed out\n");
>             }
>         }
>       else
>diff --git a/doc/dbus-specification.xml b/doc/dbus-specification.xml
>index ce58fe8..1a634ca 100644
>--- a/doc/dbus-specification.xml
>+++ b/doc/dbus-specification.xml
>@@ -4663,9 +4663,9 @@
>         When an application asks to start a service by name, the bus daemon tries to
>         find a service that will own that name. It then tries to spawn the
>         executable associated with it. If this fails, it will report an
>-        error. [FIXME what happens if two .service files offer the same service;
>-        what kind of error is reported, should we have a way for the client to
>-        choose one?]
>+        error. [FIXME what happens if two .service files offer the same service
>+        for the well-known session bus? what kind of error is reported, should
>+        we have a way for the client to choose one?]
>       </para>
>       <para>
>         The executable launched will have the environment variable
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 66608: 82205 | 82206 | 82314 | 82315 | 85914 | 85915 | 85957 | 87276

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.