Attachment 86529 Details for Bug 69797 – stop using tp_text_channel_get_pending_messages()

[patch] stop using tp_text_channel_get_pending_messages()

0006-stop-using-tp_text_channel_get_pending_messages.patch (text/plain), 1.22 KB, created by Guillaume Desmottes on 2013-09-25 09:04:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guillaume Desmottes

Created: 2013-09-25 09:04:31 UTC

Size: 1.22 KB

patch

obsolete

>From 54dc1def7a7dcaee992a0d615ecd685e0f11e5f2 Mon Sep 17 00:00:00 2001
>From: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
>Date: Mon, 23 Sep 2013 16:28:34 +0200
>Subject: [PATCH 06/15] stop using tp_text_channel_get_pending_messages()
>
>https://bugs.freedesktop.org/show_bug.cgi?id=69797
>---
> telepathy-logger/text-channel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/telepathy-logger/text-channel.c b/telepathy-logger/text-channel.c
>index 67c0671..f34eeec 100644
>--- a/telepathy-logger/text-channel.c
>+++ b/telepathy-logger/text-channel.c
>@@ -437,7 +437,7 @@ store_pending_messages (TplTextChannel *self)
>     }
> 
>   pending_messages =
>-    tp_text_channel_get_pending_messages (TP_TEXT_CHANNEL (self));
>+    tp_text_channel_dup_pending_messages (TP_TEXT_CHANNEL (self));
> 
>   pending_messages = g_list_sort (pending_messages,
>       (GCompareFunc) pending_message_compare_id);
>@@ -506,7 +506,7 @@ store_pending_messages (TplTextChannel *self)
> 
>   g_list_foreach (cached_messages, (GFunc) g_free, NULL);
>   g_list_free (cached_messages);
>-  g_list_free (pending_messages);
>+  g_list_free_full (pending_messages, g_object_unref);
> 
> 
>   /* We need to remove before we log to avoid collisions */
>-- 
>1.8.3.1
>

Actions: View | Splinter Review

Attachments on bug 69797: 86523 | 86524 | 86525 | 86526 | 86528 | 86529 | 86530 | 86531 | 86532 | 86533 | 86534 | 86535 | 86536 | 86537 | 86538

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.