Attachment 86582 Details for Bug 69822 – [MC master, 1/3] Include config.h in every .c file (again)

[patch] [MC master, 1/3] Include config.h in every .c file (again)

0001-Include-config.h-in-every-.c-file-again.patch (text/plain), 1.75 KB, created by Simon McVittie on 2013-09-25 17:33:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-09-25 17:33:53 UTC

Size: 1.75 KB

patch

obsolete

>From 26f2b18457506d58daea3089fb41ab8ef5c3d1f0 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Fri, 19 Jul 2013 18:02:29 +0100
>Subject: [PATCH 1/3] Include config.h in every .c file (again)
>
>This is potentially important if config.h includes things that affect
>compilation globally, like ENABLE_DEBUG, "#define inline __inline",
>or GLib, Telepathy, etc. versioned deprecation macros.
>
><config.h> rather than "config.h" as recommended in the Autoconf manual.
>---
> tests/account-store-libaccounts.c     | 1 +
> tests/twisted/mcp-account-diversion.c | 1 +
> tests/value-is-same.c                 | 2 ++
> 3 files changed, 4 insertions(+)
>
>diff --git a/tests/account-store-libaccounts.c b/tests/account-store-libaccounts.c
>index e275696..2611274 100644
>--- a/tests/account-store-libaccounts.c
>+++ b/tests/account-store-libaccounts.c
>@@ -19,6 +19,7 @@
>  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
>  */
> 
>+#include <config.h>
> #include "account-store-libaccounts.h"
> 
> #include <libaccounts-glib/ag-manager.h>
>diff --git a/tests/twisted/mcp-account-diversion.c b/tests/twisted/mcp-account-diversion.c
>index a996764..923f51b 100644
>--- a/tests/twisted/mcp-account-diversion.c
>+++ b/tests/twisted/mcp-account-diversion.c
>@@ -19,6 +19,7 @@
>  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
>  */
> 
>+#include <config.h>
> #include <mission-control-plugins/mission-control-plugins.h>
> 
> #define DONT_DIVERT "fakecm/fakeprotocol/dontdivert"
>diff --git a/tests/value-is-same.c b/tests/value-is-same.c
>index 1f7854b..7409790 100644
>--- a/tests/value-is-same.c
>+++ b/tests/value-is-same.c
>@@ -23,6 +23,8 @@
>  *
>  */
> 
>+#include <config.h>
>+
> /* Yes, this is a hack */
> #include "mcd-account.c"
> 
>-- 
>1.8.4.rc3
>

Actions: View | Splinter Review

Attachments on bug 69822: 86579 | 86580 | 86581 | 86582 | 86583 | 86584

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.