Attachment 87247 Details for Bug 54867 – 0001-r300g-compiler-Fix-unsigned-comparison-with-less-tha.patch

[patch] 0001-r300g-compiler-Fix-unsigned-comparison-with-less-tha.patch

0001-r300g-compiler-Fix-unsigned-comparison-with-less-tha.patch (text/plain), 1.12 KB, created by David Heidelberg (okias) on 2013-10-07 16:09:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Heidelberg (okias)

Created: 2013-10-07 16:09:51 UTC

Size: 1.12 KB

patch

obsolete

>From 52903e4a87ed2d0e420ba2c937f7a7dbbda25e7c Mon Sep 17 00:00:00 2001
>From: David Heidelberger <david.heidelberger@ixit.cz>
>Date: Mon, 7 Oct 2013 18:06:11 +0200
>Subject: [PATCH] r300g/compiler: Fix unsigned comparison with less than zero
>
>rc_find_free_temporary_list() returns signed integer
>(in case of lack of free temporary registers returns -1),
>so new_index in radeon_rename_regs() should be signed.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=54867
>---
> src/gallium/drivers/r300/compiler/radeon_rename_regs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/gallium/drivers/r300/compiler/radeon_rename_regs.c b/src/gallium/drivers/r300/compiler/radeon_rename_regs.c
>index 7b29ece..498b88f 100644
>--- a/src/gallium/drivers/r300/compiler/radeon_rename_regs.c
>+++ b/src/gallium/drivers/r300/compiler/radeon_rename_regs.c
>@@ -68,7 +68,7 @@ void rc_rename_regs(struct radeon_compiler *c, void *user)
> 	variables = rc_get_variables(c);
> 
> 	for (var_ptr = variables; var_ptr; var_ptr = var_ptr->Next) {
>-		unsigned new_index;
>+		int new_index;
> 		unsigned writemask;
> 		struct rc_variable * var = var_ptr->Item;
> 
>-- 
>1.8.3.2
>

Actions: View | Splinter Review

Attachments on bug 54867: 80074 | 87247

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.