Attachment 87740 Details for Bug 70077 – construct_contact_statuses_cb: assert that handles are valid

[patch] construct_contact_statuses_cb: assert that handles are valid

0001-construct_contact_statuses_cb-assert-that-handles-ar.patch (text/plain), 1020 bytes, created by Guillaume Desmottes on 2013-10-16 16:09:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guillaume Desmottes

Created: 2013-10-16 16:09:20 UTC

Size: 1020 bytes

patch

obsolete

>From d3f72cf6986452531d85bef2c2467675db079f66 Mon Sep 17 00:00:00 2001
>From: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
>Date: Wed, 16 Oct 2013 12:04:19 -0400
>Subject: [PATCH] construct_contact_statuses_cb: assert that handles are valid
>
>tp-glib checks that for us.
>---
> src/conn-presence.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/conn-presence.c b/src/conn-presence.c
>index 6d1a235..ab9585f 100644
>--- a/src/conn-presence.c
>+++ b/src/conn-presence.c
>@@ -185,8 +185,8 @@ construct_contact_statuses_cb (GObject *obj,
>   TpHandleRepoIface *handle_repo = tp_base_connection_get_handles (base,
>       TP_HANDLE_TYPE_CONTACT);
> 
>-  if (!tp_handles_are_valid (handle_repo, contact_handles, FALSE, NULL))
>-    return NULL;
>+  g_return_val_if_fail (tp_handles_are_valid (handle_repo, contact_handles,
>+        FALSE, NULL), NULL);
> 
>   contact_statuses = g_hash_table_new_full (g_direct_hash, g_direct_equal, NULL,
>       (GDestroyNotify) tp_presence_status_free);
>-- 
>1.8.3.1
>

Actions: View | Splinter Review

Attachments on bug 70077: 87740

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.