Attachment 88057 Details for Bug 70654 – possible fix

[patch] possible fix

0001-drm-radeon-dpm-retain-user-selected-performance-leve.patch (text/plain), 1.53 KB, created by Alex Deucher on 2013-10-23 21:33:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2013-10-23 21:33:43 UTC

Size: 1.53 KB

patch

obsolete

>From 9c00f2685b465252205135f17afb7f08022d7169 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Wed, 23 Oct 2013 17:31:42 -0400
>Subject: [PATCH] drm/radeon/dpm: retain user selected performance level across
> state changes
>
>If the user has forced the state high or low, retain that preference
>even when we switch power states.
>
>Fixes:
>https://bugs.freedesktop.org/show_bug.cgi?id=70654
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>---
> drivers/gpu/drm/radeon/radeon_pm.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c
>index 94b85a8..4d1b23e 100644
>--- a/drivers/gpu/drm/radeon/radeon_pm.c
>+++ b/drivers/gpu/drm/radeon/radeon_pm.c
>@@ -922,12 +922,16 @@ static void radeon_dpm_change_power_state_locked(struct radeon_device *rdev)
> 	radeon_dpm_post_set_power_state(rdev);
> 
> 	if (rdev->asic->dpm.force_performance_level) {
>-		if (rdev->pm.dpm.thermal_active)
>+		if (rdev->pm.dpm.thermal_active) {
>+			enum radeon_dpm_forced_level level = rdev->pm.dpm.forced_level;
> 			/* force low perf level for thermal */
> 			radeon_dpm_force_performance_level(rdev, RADEON_DPM_FORCED_LEVEL_LOW);
>-		else
>-			/* otherwise, enable auto */
>-			radeon_dpm_force_performance_level(rdev, RADEON_DPM_FORCED_LEVEL_AUTO);
>+			/* save the user's level */
>+			rdev->pm.dpm.forced_level = level;
>+		} else {
>+			/* otherwise, user selected level */
>+			radeon_dpm_force_performance_level(rdev, rdev->pm.dpm.forced_level);
>+		}
> 	}
> 
> done:
>-- 
>1.8.3.1
>

Actions: View | Splinter Review

Attachments on bug 70654: 88057

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.