Attachment 88321 Details for Bug 62917 – Add org.mpris.MediaPlayer2.Activate

[patch] Add org.mpris.MediaPlayer2.Activate

0001-Add-org.mpris.MediaPlayer2.Activate.patch (text/plain), 3.98 KB, created by Lars Uebernickel on 2013-10-29 19:32:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lars Uebernickel

Created: 2013-10-29 19:32:30 UTC

Size: 3.98 KB

patch

obsolete

>From cd07591cece834c759c5875f95df7723589a8ba2 Mon Sep 17 00:00:00 2001
>From: Lars Uebernickel <lars@uebernic.de>
>Date: Tue, 29 Oct 2013 12:20:47 -0700
>Subject: [PATCH] Add org.mpris.MediaPlayer2.Activate
>
>Activate is meant as a replacement for Raise, which doesn't support
>passing platform data to the player (such as the timestamp of the user
>action for focus stealing prevention). It is modelled after
>org.freedesktop.Application.Acticate in the desktop entry spec.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=62917
>---
> spec/org.mpris.MediaPlayer2.xml | 44 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
>diff --git a/spec/org.mpris.MediaPlayer2.xml b/spec/org.mpris.MediaPlayer2.xml
>index aca33e6..51bbc52 100644
>--- a/spec/org.mpris.MediaPlayer2.xml
>+++ b/spec/org.mpris.MediaPlayer2.xml
>@@ -4,8 +4,13 @@
> <annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal" value="true"/>
> 
> <method name="Raise" tp:name-for-bindings="Raise">
>+ <annotation name="org.freedesktop.DBus.Deprecated" value="true"/>
> <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
> 
>+ Note: this method is deprecated in favor of
>+ <tp:member-ref>Activate</tp:member-ref>.
>+ 
>+ 
> Brings the media player's user interface to the front using any
> appropriate mechanism available.
> 
>@@ -18,6 +23,31 @@
> </tp:docstring>
> </method>
> 
>+ <method name="Activate" tp:name-for-bindings="Activate">
>+ <arg direction="in" type="a{sv}" name="platform_data" />
>+ <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
>+ 
>+ Brings the media player's user interface to the front using any
>+ appropriate mechanism available.
>+ 
>+ 
>+ The media player may be unable to control how its user interface
>+ is displayed, or it may not have a graphical user interface at all.
>+ In this case, the <tp:member-ref>CanActivate</tp:member-ref> property is
>+ false and this method does nothing.
>+ 
>+ 
>+ The <literal>platform-data</literal> parameter is used in a similar way to
>+ environment variables. Currently, the only specified field if
>+ <literal>desktop-startup-id</literal>. This should be a string of
>+ the same value as would be stored in the <varname>DESKTOP_STARTUP_ID</varname>
>+ environment variable, as specified by the
>+ <ulink url="http://www.freedesktop.org/Standards/startup-notification-spec">Startup
>+ Notification Protocol Specification</ulink>.
>+ 
>+ </tp:docstring>
>+ </method>
>+
> <method name="Quit" tp:name-for-bindings="Quit">
> <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
> Causes the media player to stop running.
>@@ -111,8 +141,13 @@
> </property>
> 
> <property name="CanRaise" type="b" tp:name-for-bindings="Can_Raise" access="read">
>+ <annotation name="org.freedesktop.DBus.Deprecated" value="true"/>
> <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
> 
>+ Note: this property is deprecated in favor of
>+ <tp:member-ref>CanActivate</tp:member-ref>.
>+ 
>+ 
> If false, calling
> <tp:member-ref>Raise</tp:member-ref> will have no effect, and may
> raise a NotSupported error. If true, calling
>@@ -123,6 +158,15 @@
> </tp:docstring>
> </property>
> 
>+ <property name="CanActivate" type="b" tp:name-for-bindings="Can_Activate" access="read">
>+ <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
>+ 
>+ Indicates whether this player supports the
>+ <tp:member-ref>Activate<tp:member-ref> method call.
>+ 
>+ </tp:docstring>
>+ </property>
>+
> <property name="HasTrackList" type="b" tp:name-for-bindings="Has_TrackList" access="read">
> <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
> 
>-- 
>1.8.3.2
>

Actions: View | Splinter Review

Attachments on bug 62917: 88321

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.