Attachment 88347 Details for Bug 71048 – [01/15] inspect-cm.py: on errors, exit rather than blocking forever

[patch] [01/15] inspect-cm.py: on errors, exit rather than blocking forever

0001-inspect-cm.py-on-errors-exit-rather-than-blocking-fo.patch (text/plain), 1.39 KB, created by Simon McVittie on 2013-10-30 12:53:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-10-30 12:53:58 UTC

Size: 1.39 KB

patch

obsolete

>From fd0a831134c7dd4beae511a15efff996f92582de Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Tue, 22 Oct 2013 19:11:53 +0100
>Subject: [PATCH 01/15] inspect-cm.py: on errors, exit rather than blocking
> forever
>
>---
> examples/client/python/inspect-cm.py | 23 +++++++++++++----------
> 1 file changed, 13 insertions(+), 10 deletions(-)
>
>diff --git a/examples/client/python/inspect-cm.py b/examples/client/python/inspect-cm.py
>index c653cf7..0564078 100644
>--- a/examples/client/python/inspect-cm.py
>+++ b/examples/client/python/inspect-cm.py
>@@ -28,9 +28,11 @@ def describe(cm):
>                 print("\t\tNo default")
> 
> def manager_prepared_cb(cm, result, loop):
>-    cm.prepare_finish(result)
>-    describe(cm)
>-    loop.quit()
>+    try:
>+        cm.prepare_finish(result)
>+        describe(cm)
>+    finally:
>+        loop.quit()
> 
> def inspect(name):
>     cm = Tp.ConnectionManager(
>@@ -41,13 +43,14 @@ def inspect(name):
>     cm.prepare_async(None, cm, loop)
> 
> def cms_cb(source, result, loop):
>-    cms = Tp.list_connection_managers_finish(result)
>-
>-    for cm in cms:
>-        describe(cm)
>-        print("")
>-
>-    loop.quit()
>+    try:
>+        cms = Tp.list_connection_managers_finish(result)
>+
>+        for cm in cms:
>+            describe(cm)
>+            print("")
>+    finally:
>+        loop.quit()
> 
> if __name__ == '__main__':
>     loop = GObject.MainLoop()
>-- 
>1.8.4.rc3
>

Actions: View | Splinter Review

Attachments on bug 71048: 88347 | 88348 | 88349 | 88350 | 88351 | 88352 | 88353 | 88354 | 88355 | 88356 | 88357 | 88358 | 88359 | 88360 | 88361 | 89036 | 89037

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.