Attachment 89172 Details for Bug 64225 – Possible Fix #2

[patch] Possible Fix #2

0001-radeon-compute-Unconditionally-inline-all-functions.patch (text/plain), 2.20 KB, created by Tom Stellard on 2013-11-14 02:56:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tom Stellard

Created: 2013-11-14 02:56:02 UTC

Size: 2.20 KB

patch

obsolete

>From d264d0dc2713e9093076a613a8032fed3b572377 Mon Sep 17 00:00:00 2001
>From: Tom Stellard <thomas.stellard@amd.com>
>Date: Wed, 13 Nov 2013 18:52:14 -0800
>Subject: [PATCH] radeon/compute: Unconditionally inline all functions
>
>We need to do this until function calls are supported.
>---
> src/gallium/drivers/radeon/radeon_llvm_util.c | 24 ++++++++++++++++++++++--
> 1 file changed, 22 insertions(+), 2 deletions(-)
>
>diff --git a/src/gallium/drivers/radeon/radeon_llvm_util.c b/src/gallium/drivers/radeon/radeon_llvm_util.c
>index 7192dee..02a11b5 100644
>--- a/src/gallium/drivers/radeon/radeon_llvm_util.c
>+++ b/src/gallium/drivers/radeon/radeon_llvm_util.c
>@@ -30,6 +30,7 @@
> #include <llvm-c/BitReader.h>
> #include <llvm-c/Core.h>
> #include <llvm-c/Target.h>
>+#include <llvm-c/Transforms/IPO.h>
> #include <llvm-c/Transforms/PassManagerBuilder.h>
> 
> LLVMModuleRef radeon_llvm_parse_bitcode(const unsigned char * bitcode,
>@@ -58,9 +59,28 @@ static void radeon_llvm_optimize(LLVMModuleRef mod)
> 	LLVMTargetDataRef TD = LLVMCreateTargetData(data_layout);
> 	LLVMPassManagerBuilderRef builder = LLVMPassManagerBuilderCreate();
> 	LLVMPassManagerRef pass_manager = LLVMCreatePassManager();
>-	LLVMAddTargetData(TD, pass_manager);
> 
>-	LLVMPassManagerBuilderUseInlinerWithThreshold(builder, 1000000000);
>+	/* Functions calls are not supported yet, so we need to inline
>+	 * everything.  The most efficient way to do this is to add
>+	 * the always_inline attribute to all non-kernel functions
>+	 * and then run the Always Inline pass.  The Always Inline
>+	 * pass will automaically inline functions with this attribute
>+	 * and does not perform the expensive cost analysis that the normal
>+	 * inliner does.
>+	 */
>+
>+	LLVMValueRef fn;
>+	LLVMValueRef last_fn = LLVMGetLastFunction(mod);
>+	for (fn = LLVMGetFirstFunction(mod); fn != last_fn;
>+						fn = LLVMGetNextFunction(fn)) {
>+		/* All the non-kernel functions have internal linkage */
>+		if (LLVMGetLinkage(fn) == LLVMInternalLinkage) {
>+			LLVMAddFunctionAttr(fn, LLVMAlwaysInlineAttribute);
>+		}
>+	}
>+
>+	LLVMAddTargetData(TD, pass_manager);
>+	LLVMAddAlwaysInlinerPass(pass_manager);
> 	LLVMPassManagerBuilderPopulateModulePassManager(builder, pass_manager);
> 
> 	LLVMRunPassManager(pass_manager, mod);
>-- 
>1.8.1.4
>

Actions: View | Splinter Review

Attachments on bug 64225: 78869 | 79753 | 86763 | 89172

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.