Attachment 89768 Details for Bug 71975 – possible fix

[patch] possible fix

0001-drm-radeon-program-DCE2-audio-dto-just-like-DCE3.patch (text/plain), 1.60 KB, created by Alex Deucher on 2013-11-25 18:22:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2013-11-25 18:22:44 UTC

Size: 1.60 KB

patch

obsolete

>From 2ea03241a171ec5ce1dac92e2f7d27c83cf694c4 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Mon, 25 Nov 2013 13:20:59 -0500
>Subject: [PATCH] drm/radeon: program DCE2 audio dto just like DCE3
>
>Seems to work like the DCE3 version despite what
>the register spec says.
>
>bug:
>https://bugs.freedesktop.org/show_bug.cgi?id=71975
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>Cc: stable@vger.kernel.org
>---
> drivers/gpu/drm/radeon/r600_hdmi.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon/r600_hdmi.c
>index 4b89262..b7d3ecb 100644
>--- a/drivers/gpu/drm/radeon/r600_hdmi.c
>+++ b/drivers/gpu/drm/radeon/r600_hdmi.c
>@@ -304,9 +304,9 @@ void r600_audio_set_dto(struct drm_encoder *encoder, u32 clock)
> 			WREG32(DCCG_AUDIO_DTO1_MODULE, dto_modulo);
> 			WREG32(DCCG_AUDIO_DTO_SELECT, 1); /* select DTO1 */
> 		}
>-	} else if (ASIC_IS_DCE3(rdev)) {
>+	} else {
> 		/* according to the reg specs, this should DCE3.2 only, but in
>-		 * practice it seems to cover DCE3.0/3.1 as well.
>+		 * practice it seems to cover DCE2.0/3.0/3.1 as well.
> 		 */
> 		if (dig->dig_encoder == 0) {
> 			WREG32(DCCG_AUDIO_DTO0_PHASE, base_rate * 100);
>@@ -317,10 +317,6 @@ void r600_audio_set_dto(struct drm_encoder *encoder, u32 clock)
> 			WREG32(DCCG_AUDIO_DTO1_MODULE, clock * 100);
> 			WREG32(DCCG_AUDIO_DTO_SELECT, 1); /* select DTO1 */
> 		}
>-	} else {
>-		/* according to the reg specs, this should be DCE2.0 and DCE3.0/3.1 */
>-		WREG32(AUDIO_DTO, AUDIO_DTO_PHASE(base_rate / 10) |
>-		       AUDIO_DTO_MODULE(clock / 10));
> 	}
> }
> 
>-- 
>1.8.3.1
>

Actions: View | Splinter Review

Attachments on bug 71975: 89768

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.