Attachment 90603 Details for Bug 72596 – Clean up cache dir

[patch] Clean up cache dir

0017-clean-up-cache-dir.patch (text/plain), 1.43 KB, created by Gunnar Hjalmarsson on 2013-12-11 12:01:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Gunnar Hjalmarsson

Created: 2013-12-11 12:01:05 UTC

Size: 1.43 KB

patch

obsolete

>Description: Remove user cache files if user account no longer exists
>Bug-Ubuntu: https://launchpad.net/bugs/1259562
>Forwarded: https://bugs.freedesktop.org/72596
>Author: Robert Ancell <robert.ancell@canonical.com>
>
>--- accountsservice-0.6.35.orig/src/daemon.c	2013-10-15 22:25:19.000000000 +0200
>+++ accountsservice-0.6.35/src/daemon.c	2013-12-11 10:25:41.235730180 +0100
>@@ -371,15 +371,21 @@
>                 /* Only load files in this directory */
>                 filename = g_build_filename (USERDIR, name, NULL);
>                 regular = g_file_test (filename, G_FILE_TEST_IS_REGULAR);
>-                g_free (filename);
> 
>                 if (regular) {
>                         pwent = getpwnam (name);
>-                        if (pwent == NULL)
>-                                g_debug ("user '%s' in cache dir but not present on system", name);
>-                        else
>+                        if (pwent == NULL) {
>+                                g_debug ("user '%s' in cache dir but not present on system, removing", name);
>+                                g_remove (filename);
>+                                g_free (filename);
>+                        }
>+                        else {
>+                                g_free (filename);
>                                 return pwent;
>+                        }
>                 }
>+                else
>+                        g_free (filename);
>         }
> 
>         /* Last iteration */

Actions: View | Splinter Review

Attachments on bug 72596: 90603 | 90679 | 90741 | 93452 | 93453

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.