Attachment 90723 Details for Bug 72283 – possible fix

[patch] possible fix

0001-drm-radeon-check-for-zero-sad_count-in-dce6_afmt_wri.patch (text/plain), 1.04 KB, created by Alex Deucher on 2013-12-13 14:07:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Deucher

Created: 2013-12-13 14:07:59 UTC

Size: 1.04 KB

patch

obsolete

>From a80649876ff9784ecc97fb79d1c38e2eac45dfb2 Mon Sep 17 00:00:00 2001
>From: Alex Deucher <alexander.deucher@amd.com>
>Date: Fri, 13 Dec 2013 09:05:49 -0500
>Subject: [PATCH] drm/radeon: check for zero sad_count in
> dce6_afmt_write_speaker_allocation
>
>Some EDIDs may have an empty speaker allocation block.
>
>bug:
>https://bugs.freedesktop.org/show_bug.cgi?id=72283
>
>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>Cc: stable@vger.kernel.org
>---
> drivers/gpu/drm/radeon/dce6_afmt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/radeon/dce6_afmt.c b/drivers/gpu/drm/radeon/dce6_afmt.c
>index de86493..a5493b7 100644
>--- a/drivers/gpu/drm/radeon/dce6_afmt.c
>+++ b/drivers/gpu/drm/radeon/dce6_afmt.c
>@@ -174,7 +174,7 @@ void dce6_afmt_write_speaker_allocation(struct drm_encoder *encoder)
> 	}
> 
> 	sad_count = drm_edid_to_speaker_allocation(radeon_connector->edid, &sadb);
>-	if (sad_count < 0) {
>+	if (sad_count <= 0) {
> 		DRM_ERROR("Couldn't read Speaker Allocation Data Block: %d\n", sad_count);
> 		return;
> 	}
>-- 
>1.8.3.1
>

Actions: View | Splinter Review

Attachments on bug 72283: 90196 | 90534 | 90535 | 90699 | 90700 | 90723 | 90731 | 90732 | 90735 | 90736 | 90737 | 90739

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.