Attachment 90809 Details for Bug 72088 – Fixes double frees, see my previous comment for a complete explanation.

[patch] Fixes double frees, see my previous comment for a complete explanation.

double_free.patch (text/plain), 1.29 KB, created by Mario Rugiero on 2013-12-15 23:06:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mario Rugiero

Created: 2013-12-15 23:06:49 UTC

Size: 1.29 KB

patch

obsolete

>diff --git a/src/via_driver.c b/src/via_driver.c
>index 352f89b..2b49190 100644
>--- a/src/via_driver.c
>+++ b/src/via_driver.c
>@@ -1106,7 +1106,6 @@ VIAPreInit(ScrnInfoPtr pScrn, int flags)
>      */
> 
>     if (!xf86SetDepthBpp(pScrn, 0, 0, 0, Support32bppFb)) {
>-        free(pEnt);
>         VIAFreeRec(pScrn);
>         return FALSE;
>     } else {
>@@ -1121,7 +1120,6 @@ VIAPreInit(ScrnInfoPtr pScrn, int flags)
>                 xf86DrvMsg(pScrn->scrnIndex, X_ERROR,
>                            "Given depth (%d) is not supported by this driver\n",
>                            pScrn->depth);
>-                free(pEnt);
>                 VIAFreeRec(pScrn);
>                 return FALSE;
>         }
>@@ -1137,7 +1135,6 @@ VIAPreInit(ScrnInfoPtr pScrn, int flags)
>         rgb zeros = { 0, 0, 0 };
> 
>         if (!xf86SetWeight(pScrn, zeros, zeros)) {
>-            free(pEnt);
>             VIAFreeRec(pScrn);
>             return FALSE;
>         } else {
>@@ -1154,7 +1151,6 @@ VIAPreInit(ScrnInfoPtr pScrn, int flags)
>             xf86DrvMsg(pScrn->scrnIndex, X_ERROR, "Given default visual"
>                        " (%s) is not supported at depth %d.\n",
>                        xf86GetVisualName(pScrn->defaultVisual), pScrn->depth);
>-            free(pEnt);
>             VIAFreeRec(pScrn);
>             return FALSE;
>         }

Actions: View | Splinter Review

Attachments on bug 72088: 89921 | 90136 | 90137 | 90809 | 90810 | 90811 | 90813

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.