Attachment 90910 Details for Bug 72822 – LIBVA_DRIVER_NAME needs to be used if set at all

[patch] LIBVA_DRIVER_NAME needs to be used if set at all

0001-LIBVA_DRIVER_NAME-needs-to-be-used-if-set-at-all.patch (text/plain), 996 bytes, created by Matthew Waters on 2013-12-18 05:47:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthew Waters

Created: 2013-12-18 05:47:42 UTC

Size: 996 bytes

patch

obsolete

>From ae23753166cf23d6766dd31a3641d44a91e12202 Mon Sep 17 00:00:00 2001
>From: Matthew Waters <ystreet00@gmail.com>
>Date: Wed, 18 Dec 2013 16:36:41 +1100
>Subject: [PATCH] LIBVA_DRIVER_NAME needs to be used if set at all
>
>va_GetDriverName fails to find the vdpau driver returning
>something != SUCCESS and the driver name is not used at all.
>---
> va/va.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/va/va.c b/va/va.c
>index 9ad2db4..834c10d 100644
>--- a/va/va.c
>+++ b/va/va.c
>@@ -460,8 +460,7 @@ VAStatus vaInitialize (
>     va_infoMessage("va_getDriverName() returns %d\n", vaStatus);
> 
>     driver_name_env = getenv("LIBVA_DRIVER_NAME");
>-    if ((VA_STATUS_SUCCESS == vaStatus) &&
>-        driver_name_env && (geteuid() == getuid())) {
>+    if (driver_name_env && (geteuid() == getuid())) {
>         /* Don't allow setuid apps to use LIBVA_DRIVER_NAME */
>         if (driver_name) /* memory is allocated in va_getDriverName */
>             free(driver_name);
>-- 
>1.8.5.2
>

Actions: View | Splinter Review

Attachments on bug 72822: 90910 | 117764

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.