Attachment 92009 Details for Bug 68524 – use mi fallbacks for lines

[patch] use mi fallbacks for lines

0001-increase-performance-of-lines-fallback.patch (text/plain), 1.71 KB, created by Dave Airlie on 2014-01-13 23:41:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dave Airlie

Created: 2014-01-13 23:41:16 UTC

Size: 1.71 KB

patch

obsolete

>From 7df096eeca5fdbe603e5bb62caa4afa6612abe68 Mon Sep 17 00:00:00 2001
>From: Eric Anholt <eric@anholt.net>
>Date: Tue, 14 Jan 2014 09:39:47 +1000
>Subject: [PATCH] increase performance of lines fallback.
>
>[airlied: ported from Eric's X server branch from talking at LCA].
>
>Signed-off-by: Dave Airlie <airlied@redhat.com>
>---
> src/glamor_polylines.c | 25 ++++++++++++-------------
> 1 file changed, 12 insertions(+), 13 deletions(-)
>
>diff --git a/src/glamor_polylines.c b/src/glamor_polylines.c
>index e723e95..a71655f 100644
>--- a/src/glamor_polylines.c
>+++ b/src/glamor_polylines.c
>@@ -51,7 +51,7 @@ _glamor_poly_lines(DrawablePtr drawable, GCPtr gc, int mode, int n,
> 		/* This ends up in miSetSpans, which is accelerated as well as we
> 		 * can hope X wide lines will be.
> 		 */
>-		goto wide_line;
>+		goto fail;
> 	}
> 	if (gc->lineStyle != LineSolid) {
> 		glamor_fallback
>@@ -104,18 +104,17 @@ _glamor_poly_lines(DrawablePtr drawable, GCPtr gc, int mode, int n,
> 	    && glamor_ddx_fallback_check_gc(gc))
> 		return FALSE;
> 
>-	if (gc->lineWidth == 0) {
>-		if (glamor_prepare_access(drawable, GLAMOR_ACCESS_RW)) {
>-			if (glamor_prepare_access_gc(gc)) {
>-				fbPolyLine(drawable, gc, mode, n, points);
>-				glamor_finish_access_gc(gc);
>-			}
>-			glamor_finish_access(drawable, GLAMOR_ACCESS_RW);
>-		}
>-	} else {
>-wide_line:
>-		/* fb calls mi functions in the lineWidth != 0 case. */
>-		fbPolyLine(drawable, gc, mode, n, points);
>+        switch (gc->lineStyle) {
>+	case LineSolid:
>+		if (gc->lineWidth == 0)
>+			miZeroLine(drawable, gc, mode, n, points);
>+		else
>+			miWideLine(drawable, gc, mode, n, points);
>+		break;
>+	case LineOnOffDash:
>+	case LineDoubleDash:
>+		miWideDash(drawable, gc, mode, n, points);
>+		break;
> 	}
> 	return TRUE;
> }
>-- 
>1.8.3.1
>

Actions: View | Splinter Review

Attachments on bug 68524: 84596 | 84597 | 91802 | 91804 | 91813 | 91814 | 92009 | 92331 | 92332 | 92333 | 92337 | 92338 | 97702

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.