Attachment 92295 Details for Bug 73689 – inotify: make sure we set the close-on-exec flag

[patch] inotify: make sure we set the close-on-exec flag

0001-inotify-make-sure-we-set-the-close-on-exec-flag.patch (text/plain), 1011 bytes, created by Simon McVittie on 2014-01-17 17:13:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2014-01-17 17:13:58 UTC

Size: 1011 bytes

patch

obsolete

>From bdbba583f039900ddd6d2283deb5aa40b8aea3b4 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Fri, 17 Jan 2014 17:10:46 +0000
>Subject: [PATCH] inotify: make sure we set the close-on-exec flag
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=73689
>---
> bus/dir-watch-inotify.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/bus/dir-watch-inotify.c b/bus/dir-watch-inotify.c
>index 49ebc72..9dd7ebb 100644
>--- a/bus/dir-watch-inotify.c
>+++ b/bus/dir-watch-inotify.c
>@@ -231,11 +231,17 @@ _init_inotify (BusContext *context)
> #else
>       inotify_fd = inotify_init ();
> #endif
>+
>       if (inotify_fd <= 0)
>         {
>           _dbus_warn ("Cannot initialize inotify\n");
>           goto out;
>         }
>+
>+      /* In the inotify_init1 case this is unnecessary but harmless,
>+       * in the other cases it's necessary */
>+      _dbus_fd_set_close_on_exec (inotify_fd);
>+
>       loop = bus_context_get_loop (context);
>       _dbus_loop_ref (loop);
> 
>-- 
>1.8.5.3
>

Actions: View | Splinter Review

Attachments on bug 73689: 92216 | 92217 | 92295 | 107237 | 107446 | 107828 | 108323 | 108348 | 108352 | 108353

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.