Attachment 92436 Details for Bug 73816 – Clone from virtual to remote

[patch] Clone from virtual to remote

0001-intel-virtual-output-Clone-modes-onto-remote-display.patch (text/plain), 1.83 KB, created by Chris Wilson on 2014-01-20 10:39:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2014-01-20 10:39:50 UTC

Size: 1.83 KB

patch

obsolete

>From 8373154e004b660ad57fd5b7ab7e058ecd2d66a3 Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Mon, 20 Jan 2014 10:38:23 +0000
>Subject: [PATCH] intel-virtual-output: Clone modes onto remote display
>
>If the user adds a mode to the VIRTUAL display and then attempts to use
>it, add that mode to the remote display.
>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> tools/virtual.c | 26 +++++++++++++++++++++++---
> 1 file changed, 23 insertions(+), 3 deletions(-)
>
>diff --git a/tools/virtual.c b/tools/virtual.c
>index f0915a4..c8e1d19 100644
>--- a/tools/virtual.c
>+++ b/tools/virtual.c
>@@ -533,6 +533,8 @@ static int clone_update_modes__randr(struct clone *clone)
> 			old = &to_res->modes[j];
> 			if (mode_equal(mode, old)) {
> 				id = old->id;
>+				DBG(("%s(%s-%s): reusing mode %ld: %s\n", __func__,
>+				     DisplayString(clone->src.dpy), clone->src.name, id, mode->name));
> 				break;
> 			}
> 		}
>@@ -1120,9 +1122,27 @@ err:
> 				}
> 			}
> 			if (dst->mode.id == 0) {
>-				DBG(("%s: failed to find suitable mode for %s\n",
>-				     DisplayString(dst->dpy), dst->name));
>-				goto err;
>+				XRRModeInfo m;
>+				char buf[256];
>+				int id;
>+
>+				/* XXX User names must be unique! */
>+				m = *src->mode;
>+				m.nameLength = snprintf(buf, sizeof(buf),
>+							"%s.%ld-%s", clone->src.name, (long)src->mode.id, mode->name);
>+				m.name = buf;
>+
>+				id = XRRCreateMode(clone->dst.dpy, clone->dst.window, &m);
>+				if (id) {
>+					DBG(("%s(%s-%s): adding mode %ld: %s\n", __func__,
>+					     DisplayString(clone->dst.dpy), clone->dst.name, id, mode->name));
>+					XRRAddOutputMode(clone->dst.dpy, clone->dst.rr_output, id);
>+					dst->mode.id = id;
>+				} else {
>+					DBG(("%s: failed to find suitable mode for %s\n",
>+					     DisplayString(dst->dpy), dst->name));
>+					goto err;
>+				}
> 			}
> 
> 			rr_crtc = dst->rr_crtc;
>-- 
>1.8.5.3
>

Actions: View | Splinter Review

Attachments on bug 73816: 92417 | 92418 | 92419 | 92420 | 92421 | 92430 | 92431 | 92434 | 92435 | 92436 | 92438 | 92439 | 92440 | 92441 | 92442 | 92671

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.