Attachment 93453 Details for Bug 72596 – On startup, clean out the data of removed users

[patch] On startup, clean out the data of removed users

0002-On-startup-clean-out-the-data-of-removed-users.patch (text/plain), 1.37 KB, created by Iain Lane on 2014-02-05 15:27:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Iain Lane

Created: 2014-02-05 15:27:59 UTC

Size: 1.37 KB

patch

obsolete

>From d597e1c7d4210eb5c5541eab83e6e620914ec0bd Mon Sep 17 00:00:00 2001
>From: Gunnar Hjalmarsson <gunnarhj@ubuntu.com>
>Date: Wed, 5 Feb 2014 14:45:19 +0000
>Subject: [PATCH 2/2] On startup, clean out the data of removed users
>
>---
> src/daemon.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
>diff --git a/src/daemon.c b/src/daemon.c
>index 5c91a7f..38fd317 100644
>--- a/src/daemon.c
>+++ b/src/daemon.c
>@@ -388,11 +388,17 @@ entry_generator_cachedir (GHashTable *users,
>                 g_free (filename);
> 
>                 if (regular) {
>+                        errno = 0;
>                         pwent = getpwnam (name);
>-                        if (pwent == NULL)
>-                                g_debug ("user '%s' in cache dir but not present on system", name);
>-                        else
>+                        if (pwent != NULL)
>                                 return pwent;
>+                        else if (errno == 0) {
>+                                g_debug ("user '%s' in cache dir but not present on system, removing", name);
>+                                remove_cache_files (name);
>+                        }
>+                        else
>+                                g_warning ("failed to check if user '%s' in cache dir is present on system: %s",
>+                                  name, g_strerror (errno));
>                 }
>         }
> 
>-- 
>1.9.rc1
>

Actions: View | Splinter Review

Attachments on bug 72596: 90603 | 90679 | 90741 | 93452 | 93453

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.