Attachment 93476 Details for Bug 71093 – mcd_storage_maybe_migrate_parameters: fix error handling

[patch] mcd_storage_maybe_migrate_parameters: fix error handling

0001-mcd_storage_maybe_migrate_parameters-fix-error-handl.patch (text/plain), 1.29 KB, created by Simon McVittie on 2014-02-05 18:47:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2014-02-05 18:47:09 UTC

Size: 1.29 KB

patch

obsolete

>From 0b50cd2fa474342fd670dc53a48d8f31654e6f95 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Wed, 5 Feb 2014 14:48:12 +0000
>Subject: [PATCH 1/7] mcd_storage_maybe_migrate_parameters: fix error handling
>
>mcp_account_storage_get_parameter() doesn't raise a GError.
>---
> src/mcd-storage.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
>diff --git a/src/mcd-storage.c b/src/mcd-storage.c
>index 68ccd43..481c3dc 100644
>--- a/src/mcd-storage.c
>+++ b/src/mcd-storage.c
>@@ -2097,7 +2097,6 @@ mcd_storage_maybe_migrate_parameters (McdStorage *self,
>       const gchar *param_name = untyped_parameters[i];
>       const TpConnectionManagerParam *param = tp_protocol_get_param (protocol,
>           param_name);
>-      GError *error = NULL;
>       GVariantType *type = NULL;
>       GVariant *value;
>       McpAccountStorageSetResult res;
>@@ -2122,10 +2121,7 @@ mcd_storage_maybe_migrate_parameters (McdStorage *self,
> 
>       if (value == NULL)
>         {
>-          DEBUG ("cannot migrate parameter '%s': %s #%d: %s",
>-              param_name, g_quark_to_string (error->domain), error->code,
>-              error->message);
>-          g_error_free (error);
>+          DEBUG ("cannot migrate parameter '%s'", param_name);
>           goto next_param;
>         }
> 
>-- 
>1.9.rc1
>

Actions: View | Splinter Review

Attachments on bug 71093: 93126 | 93127 | 93128 | 93129 | 93130 | 93131 | 93132 | 93133 | 93134 | 93137 | 93138 | 93316 | 93317 | 93318 | 93319 | 93320 | 93476 | 93477

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.