Attachment 93482 Details for Bug 74581 – [Empathy] GOA plugin: use signal-emission helpers

[patch] [Empathy] GOA plugin: use signal-emission helpers

0001-GOA-plugin-use-signal-emission-helpers.patch (text/plain), 1.52 KB, created by Simon McVittie on 2014-02-05 18:57:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2014-02-05 18:57:08 UTC

Size: 1.52 KB

patch

obsolete

>From 9cac8c6edf86f5eb146feef0198da8cc0d332988 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 27 Jan 2014 18:41:49 +0000
>Subject: [PATCH 1/2] GOA plugin: use signal-emission helpers
>
>---
> goa-mc-plugin/mcp-account-manager-goa.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/goa-mc-plugin/mcp-account-manager-goa.c b/goa-mc-plugin/mcp-account-manager-goa.c
>index 7494985..fd6beb8 100644
>--- a/goa-mc-plugin/mcp-account-manager-goa.c
>+++ b/goa-mc-plugin/mcp-account-manager-goa.c
>@@ -202,7 +202,8 @@ object_chat_changed_cb (GoaObject *object,
>   DEBUG ("%s %s", name, enabled ? "enabled" : "disabled");
> 
>   if (self->priv->ready)
>-    g_signal_emit_by_name (self, "toggled", name, enabled);
>+    mcp_account_storage_emit_toggled (MCP_ACCOUNT_STORAGE (self),
>+        name, enabled);
> }
> 
> static void
>@@ -220,7 +221,8 @@ _new_account (McpAccountManagerGoa *self,
>       g_object_ref (object));
> 
>   if (self->priv->ready)
>-    g_signal_emit_by_name (self, "created", account_name);
>+    mcp_account_storage_emit_created (MCP_ACCOUNT_STORAGE (self),
>+        account_name);
> 
>   tp_g_signal_connect_object (object, "notify::chat",
>       G_CALLBACK (object_chat_changed_cb), self, 0);
>@@ -296,7 +298,7 @@ _account_removed_cb (GoaClient *client,
>     return;
> 
>   if (self->priv->ready)
>-    g_signal_emit_by_name (self, "deleted", name);
>+    mcp_account_storage_emit_deleted (MCP_ACCOUNT_STORAGE (self), name);
> 
>   g_hash_table_remove (self->priv->accounts, name);
> 
>-- 
>1.9.rc1
>

Actions: View | Splinter Review

Attachments on bug 74581: 93478 | 93479 | 93480 | 93481 | 93482 | 93483 | 93484

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.