Attachment 93891 Details for Bug 74866 – drm/nouveau/fb: use correct ram oclass for nv1a hardware

[patch] drm/nouveau/fb: use correct ram oclass for nv1a hardware

fdo74866.patch (text/plain), 1.25 KB, created by Emil Velikov on 2014-02-12 01:34:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emil Velikov

Created: 2014-02-12 01:34:25 UTC

Size: 1.25 KB

patch

obsolete

>commit bad6bf2c27b72fb6f8791dbe19459ae75b2833d9
>Author: Emil Velikov <emil.l.velikov@gmail.com>
>Date:   Wed Feb 12 01:34:14 2014 +0000
>
>    drm/nouveau/fb: use correct ram oclass for nv1a hardware
>    
>    commit 8613e7314ac254fdd67ed46192f021d76141e4c9
>    Author: Ben Skeggs <bskeggs@redhat.com>
>    Date:   Mon Oct 21 08:50:25 2013 +1000
>    
>        drm/nouveau/fb: remove ram oclass argument from base fb constructor
>    
>    Introduced a unfortunate regression by using nv10 ram oclass for nv1a
>    hardware, causing corruption and eventually system lockup.
>    
>    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74866
>    Reported-by: John F. Godfrey <jfgodfrey@gmail.com>
>    Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
>
>diff --git a/drivers/gpu/drm/nouveau/core/subdev/fb/nv1a.c b/drivers/gpu/drm/nouveau/core/subdev/fb/nv1a.c
>index 9159a5c..265d125 100644
>--- a/drivers/gpu/drm/nouveau/core/subdev/fb/nv1a.c
>+++ b/drivers/gpu/drm/nouveau/core/subdev/fb/nv1a.c
>@@ -36,7 +36,7 @@ nv1a_fb_oclass = &(struct nv04_fb_impl) {
> 		.fini = _nouveau_fb_fini,
> 	},
> 	.base.memtype = nv04_fb_memtype_valid,
>-	.base.ram = &nv10_ram_oclass,
>+	.base.ram = &nv1a_ram_oclass,
> 	.tile.regions = 8,
> 	.tile.init = nv10_fb_tile_init,
> 	.tile.fini = nv10_fb_tile_fini,

Actions: View | Splinter Review

Attachments on bug 74866: 93891

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.