Attachment 94640 Details for Bug 75345 – drm/i915: Reject >165MHz modes w/ DVI monitors

[patch] drm/i915: Reject >165MHz modes w/ DVI monitors

0001-drm-i915-Reject-165MHz-modes-w-DVI-monitors.patch (text/plain), 1.72 KB, created by Ville Syrjala on 2014-02-24 11:20:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ville Syrjala

Created: 2014-02-24 11:20:46 UTC

Size: 1.72 KB

patch

obsolete

>From d1004c01003ff335d294b42a8b50da0c32c1c91b Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= <ville.syrjala@linux.intel.com>
>Date: Mon, 24 Feb 2014 11:37:39 +0200
>Subject: [PATCH] drm/i915: Reject >165MHz modes w/ DVI monitors
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Single-link DVI max dotclock is 165MHz. Filter out modes with higher
>dotclock when the monitor doesn't support HDMI.
>
>Also don't attempt to use 12bpc mode with DVI monitors.
>
>Cc: Adam Nielsen <a.nielsen@shikadi.net>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75345
>Signed-off-by: Ville SyrjÃ¤lÃ¤ <ville.syrjala@linux.intel.com>
>---
> drivers/gpu/drm/i915/intel_hdmi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
>index 98d68ab..aa4641d 100644
>--- a/drivers/gpu/drm/i915/intel_hdmi.c
>+++ b/drivers/gpu/drm/i915/intel_hdmi.c
>@@ -820,7 +820,7 @@ static int hdmi_portclock_limit(struct intel_hdmi *hdmi)
> {
> 	struct drm_device *dev = intel_hdmi_to_dev(hdmi);
> 
>-	if (IS_G4X(dev))
>+	if (!hdmi->has_hdmi_sink || IS_G4X(dev))
> 		return 165000;
> 	else if (IS_HASWELL(dev) || INTEL_INFO(dev)->gen >= 8)
> 		return 300000;
>@@ -874,8 +874,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,
> 	 * outputs. We also need to check that the higher clock still fits
> 	 * within limits.
> 	 */
>-	if (pipe_config->pipe_bpp > 8*3 && clock_12bpc <= portclock_limit
>-	    && HAS_PCH_SPLIT(dev)) {
>+	if (pipe_config->pipe_bpp > 8*3 && intel_hdmi->has_hdmi_sink &&
>+	    clock_12bpc <= portclock_limit && HAS_PCH_SPLIT(dev)) {
> 		DRM_DEBUG_KMS("picking bpc to 12 for HDMI output\n");
> 		desired_bpp = 12*3;
> 
>-- 
>1.8.3.2
>

Actions: View | Splinter Review

Attachments on bug 75345: 94640

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.