Attachment 95007 Details for Bug 74628 – Patch with _vdd_on/_vdd_off wrapped intel_disable_dp and EDP_FORCE_VDD bit cleared

[patch] Patch with _vdd_on/_vdd_off wrapped intel_disable_dp and EDP_FORCE_VDD bit cleared

0001-drm-i915-Don-t-just-say-it-actually-force-edp-vdd.patch (text/plain), 2.02 KB, created by Patrik Jakobsson on 2014-03-03 08:40:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Patrik Jakobsson

Created: 2014-03-03 08:40:51 UTC

Size: 2.02 KB

patch

obsolete

>From 3b04184220f47774e80ae835b008e3a997688675 Mon Sep 17 00:00:00 2001
>From: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
>Date: Mon, 3 Mar 2014 09:27:39 +0100
>Subject: [PATCH] drm/i915: Don't just say it, actually force edp vdd
>
>This solves the blank screen problem on the MacBook Air 6,2. The
>comments state that we need to force edp vdd so lets put it back. The
>EDP_FORCE_VDD bit was removed in commit:
>
>commit dff392dbd258381a6c3164f38420593f2d291e3b
>drm/i915: don't touch the VDD when disabling the panel
>
>v2: Wrap intel_disable_dp() with _vdd_on and _vdd_off
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74628
>Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
>Cc: Chris Wilson <chris@chris-wilson.co.uk>
>Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
>---
> drivers/gpu/drm/i915/intel_dp.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>index 57552eb..6da1fcb 100644
>--- a/drivers/gpu/drm/i915/intel_dp.c
>+++ b/drivers/gpu/drm/i915/intel_dp.c
>@@ -1252,7 +1252,8 @@ void ironlake_edp_panel_off(struct intel_dp *intel_dp)
> 	pp = ironlake_get_pp_control(intel_dp);
> 	/* We need to switch off panel power _and_ force vdd, for otherwise some
> 	 * panels get very unhappy and cease to work. */
>-	pp &= ~(POWER_TARGET_ON | PANEL_POWER_RESET | EDP_BLC_ENABLE);
>+	pp &= ~(POWER_TARGET_ON | PANEL_POWER_RESET | EDP_FORCE_VDD |
>+		EDP_BLC_ENABLE);
> 
> 	pp_ctrl_reg = _pp_ctrl_reg(intel_dp);
> 
>@@ -1784,9 +1785,11 @@ static void intel_disable_dp(struct intel_encoder *encoder)
> 
> 	/* Make sure the panel is off before trying to change the mode. But also
> 	 * ensure that we have vdd while we switch off the panel. */
>+	ironlake_edp_panel_vdd_on(intel_dp);
> 	ironlake_edp_backlight_off(intel_dp);
> 	intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
> 	ironlake_edp_panel_off(intel_dp);
>+	ironlake_edp_panel_vdd_off(intel_dp, true);
> 
> 	/* cpu edp my only be disable _after_ the cpu pipe/plane is disabled. */
> 	if (!(port == PORT_A || IS_VALLEYVIEW(dev)))
>-- 
>1.8.3.2
>

Actions: View | Splinter Review

Attachments on bug 74628: 93565 | 93568 | 93769 | 94966 | 94967 | 94968 | 95007

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.