Attachment 9518 Details for Bug 10571 – Patch to correct line clipping for i965

[patch] Patch to correct line clipping for i965

mesa-i965-line-clipping.patch (text/plain), 1.71 KB, created by David Moore on 2007-04-08 16:28:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Moore

Created: 2007-04-08 16:28:43 UTC

Size: 1.71 KB

patch

obsolete

>diff --git a/src/mesa/drivers/dri/i965/brw_clip_line.c b/src/mesa/drivers/dri/i965/brw_clip_line.c
>index 8318227..0103be4 100644
>--- a/src/mesa/drivers/dri/i965/brw_clip_line.c
>+++ b/src/mesa/drivers/dri/i965/brw_clip_line.c
>@@ -130,6 +130,7 @@ static void clip_and_emit_line( struct brw_clip_compile *c )
>    struct brw_instruction *plane_loop;
>    struct brw_instruction *plane_active;
>    struct brw_instruction *is_negative;
>+   struct brw_instruction *is_neg2;
>    struct brw_instruction *not_culled;
>    struct brw_reg v1_null_ud = retype(vec1(brw_null_reg()), BRW_REGISTER_TYPE_UD);
> 
>@@ -183,13 +184,20 @@ static void clip_and_emit_line( struct brw_clip_compile *c )
> 	    /* Coming back in.  We know that both cannot be negative
> 	     * because the line would have been culled in that case.
> 	     */
>-	    brw_ADD(p, c->reg.t, c->reg.dp0, negate(c->reg.dp1));
>-	    brw_math_invert(p, c->reg.t, c->reg.t);
>-	    brw_MUL(p, c->reg.t, c->reg.t, c->reg.dp0);
> 
>-	    brw_CMP(p, vec1(brw_null_reg()), BRW_CONDITIONAL_G, c->reg.t, c->reg.t0 );
>-	    brw_MOV(p, c->reg.t0, c->reg.t);
>-	    brw_set_predicate_control(p, BRW_PREDICATE_NONE);
>+	    /* If both are positive, do nothing */
>+             brw_CMP(p, vec1(brw_null_reg()), BRW_CONDITIONAL_L, c->reg.dp0, brw_imm_f(0.0));
>+             is_neg2 = brw_IF(p, BRW_EXECUTE_1);
>+             {
>+		brw_ADD(p, c->reg.t, c->reg.dp0, negate(c->reg.dp1));
>+		brw_math_invert(p, c->reg.t, c->reg.t);
>+		brw_MUL(p, c->reg.t, c->reg.t, c->reg.dp0);
>+
>+		brw_CMP(p, vec1(brw_null_reg()), BRW_CONDITIONAL_G, c->reg.t, c->reg.t0 );
>+		brw_MOV(p, c->reg.t0, c->reg.t);
>+		brw_set_predicate_control(p, BRW_PREDICATE_NONE);
>+	     }
>+	     brw_ENDIF(p, is_neg2);
> 	 }
> 	 brw_ENDIF(p, is_negative);	 
>       }

Actions: View | Splinter Review

Attachments on bug 10571: 9518 | 11044

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.