Attachment 95275 Details for Bug 75797 – Proposed fix

[patch] Proposed fix

0001-mesa-Don-t-optimize-out-glClear-if-drawbuffer-size-i.patch (text/plain), 1.06 KB, created by Kristian Høgsberg on 2014-03-07 01:04:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kristian Høgsberg

Created: 2014-03-07 01:04:29 UTC

Size: 1.06 KB

patch

obsolete

>From 1f01c3ddafb9a03be15b018f857e5f1915acf06c Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Kristian=20H=C3=B8gsberg?= <krh@bitplanet.net>
>Date: Thu, 6 Mar 2014 16:58:32 -0800
>Subject: [PATCH] mesa: Don't optimize out glClear() if drawbuffer size is 0x0
>
>The driver acquires buffer lazily and may not yet have buffers for
>a newly current drawable.  In that case the drawable size is 0x0 but
>we still need to call into the driver and make it fetch buffers and get
>the drawable size.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=75797
>---
> src/mesa/main/clear.c | 5 -----
> 1 file changed, 5 deletions(-)
>
>diff --git a/src/mesa/main/clear.c b/src/mesa/main/clear.c
>index 077c5fc..c3f7474 100644
>--- a/src/mesa/main/clear.c
>+++ b/src/mesa/main/clear.c
>@@ -155,11 +155,6 @@ _mesa_Clear( GLbitfield mask )
>       return;
>    }
> 
>-   if (ctx->DrawBuffer->Width == 0 || ctx->DrawBuffer->Height == 0 ||
>-       ctx->DrawBuffer->_Xmin >= ctx->DrawBuffer->_Xmax ||
>-       ctx->DrawBuffer->_Ymin >= ctx->DrawBuffer->_Ymax)
>-      return;
>-
>    if (ctx->RasterDiscard)
>       return;
> 
>-- 
>1.9.0
>

Actions: View | Splinter Review

Attachments on bug 75797: 95167 | 95275

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.