Attachment 96122 Details for Bug 76375 – Patch to skip empty contacts

[patch] Patch to skip empty contacts

0001-EvolutionContactSource-Skip-empty-contacts.patch (text/plain), 1.13 KB, created by Xavier Claessens on 2014-03-20 20:15:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Xavier Claessens

Created: 2014-03-20 20:15:11 UTC

Size: 1.13 KB

patch

obsolete

>From 60c2ae4d365feeecedc7bd7bfc3897b6b48f7652 Mon Sep 17 00:00:00 2001
>From: Xavier Claessens <xavier.claessens@collabora.com>
>Date: Thu, 20 Mar 2014 16:13:38 -0400
>Subject: [PATCH] EvolutionContactSource: Skip empty contacts
>
>https://bugs.freedesktop.org/show_bug.cgi?id=76375
>---
> src/backends/evolution/EvolutionContactSource.cpp | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/src/backends/evolution/EvolutionContactSource.cpp b/src/backends/evolution/EvolutionContactSource.cpp
>index 60ff94c..7aa8cab 100644
>--- a/src/backends/evolution/EvolutionContactSource.cpp
>+++ b/src/backends/evolution/EvolutionContactSource.cpp
>@@ -1031,6 +1031,11 @@ EvolutionContactSource::insertItem(const string &uid, const std::string &item, b
> {
>     EContactCXX contact(e_contact_new_from_vcard(item.c_str()), TRANSFER_REF);
>     if (contact) {
>+        if (e_vcard_get_attributes (&contact->parent) == NULL) {
>+            /* We are not inserting empty contact */
>+            return InsertItemResult("", "", ITEM_OKAY);
>+        }
>+
>         e_contact_set(contact, E_CONTACT_UID,
>                       uid.empty() ?
>                       NULL :
>-- 
>1.9.1
>

Actions: View | Splinter Review

Attachments on bug 76375: 96073 | 96074 | 96122

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.