Attachment 96374 Details for Bug 76276 – drm/i915/dp: reorder backlight pwm enable/disable wrt panel sequencing

[patch] drm/i915/dp: reorder backlight pwm enable/disable wrt panel sequencing

0001-drm-i915-dp-reorder-backlight-pwm-enable-disable-wrt.patch (text/plain), 1.75 KB, created by Jani Nikula on 2014-03-25 16:32:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jani Nikula

Created: 2014-03-25 16:32:53 UTC

Size: 1.75 KB

patch

obsolete

>From 612ff1b689ddf62e155f3e26b226fd7a398a1580 Mon Sep 17 00:00:00 2001
>From: Jani Nikula <jani.nikula@intel.com>
>Date: Tue, 25 Mar 2014 18:29:51 +0200
>Subject: [PATCH] drm/i915/dp: reorder backlight pwm enable/disable wrt panel
> sequencing
>Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
>Cc: Jani Nikula <jani.nikula@intel.com>
>
>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>---
> drivers/gpu/drm/i915/intel_dp.c |   10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>index 6f767e522b3f..1bb2937ec209 100644
>--- a/drivers/gpu/drm/i915/intel_dp.c
>+++ b/drivers/gpu/drm/i915/intel_dp.c
>@@ -1257,6 +1257,9 @@ void intel_edp_backlight_on(struct intel_dp *intel_dp)
> 	 * allowing it to appear.
> 	 */
> 	wait_backlight_on(intel_dp);
>+
>+	intel_panel_enable_backlight(intel_dp->attached_connector);
>+
> 	pp = ironlake_get_pp_control(intel_dp);
> 	pp |= EDP_BLC_ENABLE;
> 
>@@ -1264,8 +1267,6 @@ void intel_edp_backlight_on(struct intel_dp *intel_dp)
> 
> 	I915_WRITE(pp_ctrl_reg, pp);
> 	POSTING_READ(pp_ctrl_reg);
>-
>-	intel_panel_enable_backlight(intel_dp->attached_connector);
> }
> 
> void intel_edp_backlight_off(struct intel_dp *intel_dp)
>@@ -1278,8 +1279,6 @@ void intel_edp_backlight_off(struct intel_dp *intel_dp)
> 	if (!is_edp(intel_dp))
> 		return;
> 
>-	intel_panel_disable_backlight(intel_dp->attached_connector);
>-
> 	DRM_DEBUG_KMS("\n");
> 	pp = ironlake_get_pp_control(intel_dp);
> 	pp &= ~EDP_BLC_ENABLE;
>@@ -1288,6 +1287,9 @@ void intel_edp_backlight_off(struct intel_dp *intel_dp)
> 
> 	I915_WRITE(pp_ctrl_reg, pp);
> 	POSTING_READ(pp_ctrl_reg);
>+
>+	intel_panel_disable_backlight(intel_dp->attached_connector);
>+
> 	intel_dp->last_backlight_off = jiffies;
> }
> 
>-- 
>1.7.10.4
>

Actions: View | Splinter Review

Attachments on bug 76276: 95952 | 95953 | 95954 | 96374 | 96375 | 97111 | 97119 | 97120

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.