Attachment 96469 Details for Bug 76698 – Proposed patch (git format-patch)

Proposed patch (git format-patch)

0001-Lower-log-level-of-transient-dlopen-error.patch (text/plain), 1.38 KB, created by Stefan Brüns on 2014-03-27 16:35:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Brüns

Created: 2014-03-27 16:35:48 UTC

Size: 1.38 KB

patch

obsolete

>From 44b3688ee4ede2231780d248bbaa08da749610c3 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Stefan=20Br=C3=BCns?= <stefan.bruens@rwth-aachen.de>
>Date: Thu, 27 Mar 2014 16:48:32 +0100
>Subject: [PATCH] Lower log level of transient dlopen error
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>If the driver path has multiple components, the next attempt can succeed
>and the error message should be omitted for the default log level.
>If all attempts fail, the error is still logged.
>Bracket the "... trying" message with a corresponding "succeeded" or
>"failed" message when using log level verbose.
>
>Signed-off-by: Stefan BrÃ¼ns <stefan.bruens@rwth-aachen.de>
>---
> src/glx/dri_common.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/src/glx/dri_common.c b/src/glx/dri_common.c
>index 8bf4705..bdaf96f 100644
>--- a/src/glx/dri_common.c
>+++ b/src/glx/dri_common.c
>@@ -137,10 +137,12 @@ driOpenDriver(const char *driverName)
>          handle = dlopen(realDriverName, RTLD_NOW | RTLD_GLOBAL);
>       }
> 
>-      if (handle != NULL)
>+      if (handle != NULL) {
>+         InfoMessageF("dlopen %s succeeded\n", realDriverName);
>          break;
>+      }
>       else
>-         ErrorMessageF("dlopen %s failed (%s)\n", realDriverName, dlerror());
>+         InfoMessageF("dlopen %s failed (%s)\n", realDriverName, dlerror());
>    }
> 
>    if (!handle)
>-- 
>1.8.1.4
>

Actions: View

Attachments on bug 76698: 96469

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.