Attachment 98500 Details for Bug 78135 – [PATCH] drm/i915: Re-enable vblank irqs for already active pipes

[patch] [PATCH] drm/i915: Re-enable vblank irqs for already active pipes

0001-drm-i915-Re-enable-vblank-irqs-for-already-active-pi.patch (text/plain), 1.63 KB, created by Ville Syrjala on 2014-05-05 16:13:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ville Syrjala

Created: 2014-05-05 16:13:02 UTC

Size: 1.63 KB

patch

obsolete

>From c38e353eaafc420e7ba5b5e88f7df20aba3ed927 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= <ville.syrjala@linux.intel.com>
>Date: Mon, 5 May 2014 17:21:04 +0300
>Subject: [PATCH] drm/i915: Re-enable vblank irqs for already active pipes
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>If a pipe is already active when we init/resume there might not be a
>full modeset afterwards so drm_vblank_on() may not get called. In such
>a case if someone is holding a vblank reference across a suspend/resume
>cycle drm_vblank_get() called after resuming won't re-enable the vblank
>interrupts.
>
>So in order to make sure vblank interrupts get re-enabled post-resume,
>call drm_vblank_on() in intel_sanitize_crtc() if the crtc is already
>active.
>
>Signed-off-by: Ville SyrjÃ¤lÃ¤ <ville.syrjala@linux.intel.com>
>---
> drivers/gpu/drm/i915/intel_display.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>index c0b1012..1d02e32 100644
>--- a/drivers/gpu/drm/i915/intel_display.c
>+++ b/drivers/gpu/drm/i915/intel_display.c
>@@ -11424,6 +11424,10 @@ static void intel_sanitize_crtc(struct intel_crtc *crtc)
> 	reg = PIPECONF(crtc->config.cpu_transcoder);
> 	I915_WRITE(reg, I915_READ(reg) & ~PIPECONF_FRAME_START_DELAY_MASK);
> 
>+	/* restore vblank interrupts to correct state */
>+	if (crtc->active)
>+		drm_vblank_on(dev, crtc->pipe);
>+
> 	/* We need to sanitize the plane -> pipe mapping first because this will
> 	 * disable the crtc (and hence change the state) if it is wrong. Note
> 	 * that gen4+ has a fixed plane -> pipe mapping.  */
>-- 
>1.8.3.2
>

Actions: View | Splinter Review

Attachments on bug 78135: 98500

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.