Attachment 99078 Details for Bug 78724 – Retire requests during execbuffer.

[patch] Retire requests during execbuffer.

0001-drm-i915-Retire-requests-before-creating-a-new-one.patch (text/plain), 1.91 KB, created by Chris Wilson on 2014-05-15 09:42:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2014-05-15 09:42:36 UTC

Size: 1.91 KB

patch

obsolete

>From 2f82c02fbca1802b8a52cc64a18e38bbb8621694 Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Thu, 15 May 2014 10:36:18 +0100
>Subject: [PATCH] drm/i915: Retire requests before creating a new one
>
>More fallout from
>
>commit c8725f3dc0911d4354315a65150aecd8b7d0d74a
>Author: Chris Wilson <chris@chris-wilson.co.uk>
>Date:   Mon Mar 17 12:21:55 2014 +0000
>
>    drm/i915: Do not call retire_requests from wait_for_rendering
>
>is that we can completely fill all of memory using small objects, such
>that we exhaust the filp space, and spend all of our time evicting
>objects from the aperture. As such, we never fill the ring, and never
>trigger the last resort flushing in
>
>commit 1cf0ba14740d96fbf6f58a201f000a34b74f4725
>Author: Chris Wilson <chris@chris-wilson.co.uk>
>Date:   Mon May 5 09:07:33 2014 +0100
>
>    drm/i915: Flush request queue when waiting for ring space
>
>and so all the requests are left active and the objects keep that last
>active reference. Eventually the system comes to a halt as it runs out
>of memory.
>
>The impact is mainly limited to test cases as regular userspace will
>trigger retirement by manually checking whether an object is active.
>
>Testcase: igt/gem_lut_handle
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78724
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> drivers/gpu/drm/i915/i915_gem_execbuffer.c |    2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
>index 26c9d66..7ba517f 100644
>--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
>+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
>@@ -628,6 +628,8 @@ i915_gem_execbuffer_reserve(struct intel_ring_buffer *ring,
> 	bool has_fenced_gpu_access = INTEL_INFO(ring->dev)->gen < 4;
> 	int retry;
> 
>+	i915_gem_retire_requests_ring(ring);
>+
> 	vm = list_first_entry(vmas, struct i915_vma, exec_list)->vm;
> 
> 	INIT_LIST_HEAD(&ordered_vmas);
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 78724: 99058 | 99078 | 99145

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.