Attachment 99478 Details for Bug 79006 – tp-fs: fix a potential NULL dereferencing crash

[patch] tp-fs: fix a potential NULL dereferencing crash

0002-tp-fs-fix-a-potential-NULL-dereferencing-crash.patch (text/plain), 1.06 KB, created by Guillaume Desmottes on 2014-05-21 08:58:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guillaume Desmottes

Created: 2014-05-21 08:58:50 UTC

Size: 1.06 KB

patch

obsolete

>From d02cfea7413250ea4a92a01ae9e53d2c449df543 Mon Sep 17 00:00:00 2001
>From: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
>Date: Wed, 21 May 2014 10:48:01 +0200
>Subject: [PATCH 2/9] tp-fs: fix a potential NULL dereferencing crash
>
>https://bugs.freedesktop.org/show_bug.cgi?id=79006
>---
> telepathy-farstream/call-stream.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/telepathy-farstream/call-stream.c b/telepathy-farstream/call-stream.c
>index 65d2d2c..9d8d66f 100644
>--- a/telepathy-farstream/call-stream.c
>+++ b/telepathy-farstream/call-stream.c
>@@ -331,7 +331,8 @@ _tf_call_stream_push_remote_candidates (TfCallStream *self,
>       tf_call_stream_fail (self,
>           TP_CALL_STATE_CHANGE_REASON_INTERNAL_ERROR,
>           TP_ERROR_STR_MEDIA_STREAMING_ERROR,
>-          "Error setting the remote candidates: %s", error->message);
>+          "Error setting the remote candidates: %s",
>+          error != NULL ? error->message : "invalid transport type");
>       g_clear_error (&error);
>     }
>   fs_candidate_list_destroy (fscandidates);
>-- 
>1.9.0
>

Actions: View | Splinter Review

Attachments on bug 79006: 99477 | 99478 | 99479 | 99480 | 99481 | 99482 | 99483 | 99484 | 99485 | 99859 | 99861

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.