Attachment 99538 Details for Bug 70366 – PKGSYSTEM_ENABLE_FSYNC env var opt-in to fdatasync

[patch] PKGSYSTEM_ENABLE_FSYNC env var opt-in to fdatasync

0001-PKGSYSTEM_ENABLE_FSYNC-env-var-opt-in-to-fdatasync.patch (text/plain), 1.52 KB, created by Rex Dieter on 2014-05-21 21:47:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Rex Dieter

Created: 2014-05-21 21:47:34 UTC

Size: 1.52 KB

patch

obsolete

>From 7296f66a5325a377b18db754b66dba78d41ee707 Mon Sep 17 00:00:00 2001
>From: Rex Dieter <rdieter@math.unl.edu>
>Date: Wed, 21 May 2014 16:40:21 -0500
>Subject: [PATCH] PKGSYSTEM_ENABLE_FSYNC env var opt-in to fdatasync
>
>Recent fdatasync() support in update-mime-database results
>in large slowdown (x40 or more slower in some cases), and
>it's unclear the safety benefits outweigh this cost.
>
>In the meantime, make this feature opt-in via environment variable
>PKGSYSTEM_ENABLE_FSYNC
>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70366
>---
> update-mime-database.c | 32 +++++++++++++++++---------------
> 1 file changed, 17 insertions(+), 15 deletions(-)
>
>diff --git a/update-mime-database.c b/update-mime-database.c
>index c043606..09c1320 100644
>--- a/update-mime-database.c
>+++ b/update-mime-database.c
>@@ -951,21 +951,23 @@ static gboolean atomic_update(const gchar *pathname, GError **error)
> 	new_name = g_strndup(pathname, len - 4);
> 
> #ifdef HAVE_FDATASYNC
>-	fd = open(pathname, O_RDWR);
>-	if (fd == -1)
>-	{
>-		set_error_from_errno(error);
>-		goto out;
>-	}
>-	if (fdatasync(fd) == -1)
>-	{
>-		set_error_from_errno(error);
>-		goto out;
>-	}
>-	if (close(fd) == -1)
>-	{
>-		set_error_from_errno(error);
>-		goto out;
>+	if (g_getenv ("PKGSYSTEM_ENABLE_FSYNC")) {
>+		fd = open(pathname, O_RDWR);
>+		if (fd == -1)
>+		{
>+			set_error_from_errno(error);
>+			goto out;
>+		}
>+		if (fdatasync(fd) == -1)
>+		{
>+			set_error_from_errno(error);
>+			goto out;
>+		}
>+		if (close(fd) == -1)
>+		{
>+			set_error_from_errno(error);
>+			goto out;
>+		}
> 	}
> #endif
> 
>-- 
>1.9.0
>

Actions: View | Splinter Review

Attachments on bug 70366: 87427 | 90371 | 99516 | 99523 | 99538 | 99631 | 101875

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.