Attachment 100995 Details for Bug 79992 – Only discard the CPU bo if we have a GPU bo to transfer the damage to

[patch] Only discard the CPU bo if we have a GPU bo to transfer the damage to

0001-sna-Only-discard-the-CPU-bo-if-we-have-a-GPU-bo-to-t.patch (text/plain), 1.21 KB, created by Chris Wilson on 2014-06-13 17:59:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Wilson

Created: 2014-06-13 17:59:37 UTC

Size: 1.21 KB

patch

obsolete

>From 241625c48687fc820f5dc4d211ff53b5b096d30f Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Fri, 13 Jun 2014 18:56:57 +0100
>Subject: [PATCH] sna: Only discard the CPU bo if we have a GPU bo to transfer
> the damage to
>
>Fixes regression from
>commit ad0390068832ad4727371902fe41a85a53de1894 [2.99.903]
>Author: Chris Wilson <chris@chris-wilson.co.uk>
>Date:   Tue Sep 24 10:00:03 2013 +0100
>
>    sna: Separate out copy preferrence from operating in place decision
>
>Reported-by: Nick Bowler <nbowler@draconx.ca>
>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79992
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>---
> src/sna/sna_accel.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/src/sna/sna_accel.c b/src/sna/sna_accel.c
>index 72c16d3..13fe6ed 100644
>--- a/src/sna/sna_accel.c
>+++ b/src/sna/sna_accel.c
>@@ -6005,7 +6005,8 @@ static void discard_cpu_damage(struct sna *sna, struct sna_pixmap *priv)
> 	sna_damage_destroy(&priv->cpu_damage);
> 	list_del(&priv->flush_list);
> 
>-	sna_pixmap_free_cpu(sna, priv, priv->cpu);
>+	if (priv->gpu_bo && sna_pixmap_free_cpu(sna, priv, priv->cpu))
>+		sna_damage_all(&priv->gpu_damage, priv->pixmap);
> 	priv->cpu = false;
> }
> 
>-- 
>2.0.0
>

Actions: View | Splinter Review

Attachments on bug 79992: 100987 | 100988 | 100995 | 101000 | 101012

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.