Attachment 104927 Details for Bug 82671 – Fix

[patch] Fix

0002-evergreen-compute-Don-t-initialize-vertex_buffer_sta.patch (text/plain), 1.35 KB, created by Tom Stellard on 2014-08-19 23:34:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tom Stellard

Created: 2014-08-19 23:34:15 UTC

Size: 1.35 KB

patch

obsolete

>From 9b69b5f2dc5ab82d58efc54a7f4ca563161a98c0 Mon Sep 17 00:00:00 2001
>From: Tom Stellard <thomas.stellard@amd.com>
>Date: Tue, 19 Aug 2014 16:27:38 -0700
>Subject: [PATCH 2/2] evergreen/compute: Don't initialize vertex_buffer_state
> masks to 0x2
>
>cs_vertex_buffer_state.enabled_mask and
>cs_vertex_buffer_state.dirty_mask are both updated when
>r600_set_constant_buffer() is called, so we don't need to manually
>update these values.
>
>This fixes a crash with OpenCL programs that have a kernel with no
>arguments.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=82671
>
>CC: "10.2" <mesa-stable@lists.freedesktop.org>
>---
> src/gallium/drivers/r600/evergreen_compute.c | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/src/gallium/drivers/r600/evergreen_compute.c b/src/gallium/drivers/r600/evergreen_compute.c
>index 9e3404f..38b78c7 100644
>--- a/src/gallium/drivers/r600/evergreen_compute.c
>+++ b/src/gallium/drivers/r600/evergreen_compute.c
>@@ -892,9 +892,6 @@ void evergreen_init_compute_state_functions(struct r600_context *ctx)
> 	ctx->b.b.set_global_binding = evergreen_set_global_binding;
> 	ctx->b.b.launch_grid = evergreen_launch_grid;
> 
>-	/* We always use at least one vertex buffer for parameters (id = 1)*/
>-	ctx->cs_vertex_buffer_state.enabled_mask =
>-	ctx->cs_vertex_buffer_state.dirty_mask = 0x2;
> }
> 
> struct pipe_resource *r600_compute_global_buffer_create(
>-- 
>1.8.3.1
>

Actions: View | Splinter Review

Attachments on bug 82671: 104687 | 104927

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.