Attachment 105610 Details for Bug 81537 – drm/i915: debug sink dpms aux errors also on enable

[patch] drm/i915: debug sink dpms aux errors also on enable

0001-drm-i915-debug-sink-dpms-aux-errors-also-on-enable.patch (text/plain), 1.33 KB, created by Jani Nikula on 2014-09-02 13:30:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jani Nikula

Created: 2014-09-02 13:30:23 UTC

Size: 1.33 KB

patch

obsolete

>From 03d13aa62668cd6e8bac8f1f2f45bb647f27df91 Mon Sep 17 00:00:00 2001
>From: Jani Nikula <jani.nikula@intel.com>
>Date: Tue, 2 Sep 2014 16:26:32 +0300
>Subject: [PATCH] drm/i915: debug sink dpms aux errors also on enable
>Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
>Cc: Jani Nikula <jani.nikula@intel.com>
>
>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>---
> drivers/gpu/drm/i915/intel_dp.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>index d7fc2c0e9ba8..f112d7d2f8bd 100644
>--- a/drivers/gpu/drm/i915/intel_dp.c
>+++ b/drivers/gpu/drm/i915/intel_dp.c
>@@ -1553,8 +1553,6 @@ void intel_dp_sink_dpms(struct intel_dp *intel_dp, int mode)
> 	if (mode != DRM_MODE_DPMS_ON) {
> 		ret = drm_dp_dpcd_writeb(&intel_dp->aux, DP_SET_POWER,
> 					 DP_SET_POWER_D3);
>-		if (ret != 1)
>-			DRM_DEBUG_DRIVER("failed to write sink power state\n");
> 	} else {
> 		/*
> 		 * When turning on, we need to retry for 1ms to give the sink
>@@ -1568,6 +1566,10 @@ void intel_dp_sink_dpms(struct intel_dp *intel_dp, int mode)
> 			msleep(1);
> 		}
> 	}
>+
>+	if (ret != 1)
>+		DRM_DEBUG_KMS("failed to %s sink power state\n",
>+			      mode == DRM_MODE_DPMS_ON ? "enable" : "disable");
> }
> 
> static bool intel_dp_get_hw_state(struct intel_encoder *encoder,
>-- 
>1.9.1
>

Actions: View | Splinter Review

Attachments on bug 81537: 103107 | 103108 | 103109 | 103225 | 103240 | 103253 | 103254 | 103290 | 103291 | 103293 | 103294 | 103295 | 105610 | 110085

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.